Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[G4] Update geant4 to 4.10.6.0 #5424

Merged

Conversation

mrodozov
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_1_X/geant4.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

mrodozov commented Dec 13, 2019

test parameters

@mrodozov
Copy link
Contributor Author

mrodozov commented Dec 13, 2019

please test
lets see if this will work

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-externals/geant4#43
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3965/console Started: 2019/12/13 16:36

@cmsbuild
Copy link
Contributor

-1

Tested at: f2436f3

  • Build:

I found compilation warning when building: See details on the summary page.

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3c1ae/3965/summary.html

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3966/console Started: 2019/12/13 17:01

@cmsbuild
Copy link
Contributor

Pull request #5424 was updated.

@cmsbuild
Copy link
Contributor

-1

Tested at: a32fc85

CMSSW: CMSSW_11_1_GEANT4_X_2019-12-12-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e52804/3966/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_GEANT4_X_2019-12-12-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomSummary.cc 
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_GEANT4_X_2019-12-12-2300/src/SimG4Core/PrintGeomInfo/src/PrintMaterialBudgetInfo.cc 
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_GEANT4_X_2019-12-12-2300/src/SimG4Core/PrintGeomInfo/src/PrintSensitive.cc 
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_GEANT4_X_2019-12-12-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomInfoAction.cc 
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_GEANT4_X_2019-12-12-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomInfoAction.cc: In member function 'void PrintGeomInfoAction::dumpG4LVLeaf(G4LogicalVolume*, unsigned int, unsigned int, std::ostream&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_GEANT4_X_2019-12-12-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomInfoAction.cc:176:23: error: comparison of integer expressions of different signedness: 'int' and 'size_t' {aka 'long unsigned int'} [-Werror=sign-compare]
   for (int ii = 0; ii < lv->GetNoDaughters(); ii++) {
                    ~~~^~~~~~~~~~~~~~~~~~~~~~
cc1plus: some warnings being treated as errors
gmake: *** [tmp/slc7_amd64_gcc820/src/SimG4Core/PrintGeomInfo/src/SimG4CorePrintGeomInfo/PrintGeomInfoAction.cc.o] Error 1
>> Compiling bigobj edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_GEANT4_X_2019-12-12-2300/src/SimG4Core/PrintGeomInfo/src/module.cc 


@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

Pull request #5424 was updated.

build full cmssw to check if it works
@cmsbuild
Copy link
Contributor

Pull request #5424 was updated.

the "old commit" was on a branch that doesn't exist anymore
@cmsbuild
Copy link
Contributor

Pull request #5424 was updated.

@smuzaffar
Copy link
Contributor

test parameters

  • release = CMSSW_11_1_GEANT4_X
  • full_cmssw = true

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 19, 2019

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

-1

Tested at: e857c18

CMSSW: CMSSW_11_1_GEANT4_X_2019-12-19-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e52804/4071/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals AddOn

  • Unit Tests:

I found errors in the following unit tests:

---> test import-tables had ERRORS
---> test testTables had ERRORS
---> test materialBudgetTrackerPlots had ERRORS
---> test testTauEmbeddingProducers had ERRORS

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

250202.181 step2
runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step2_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

  • AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_MC.root : FAILED - time: date Fri Dec 20 03:48:21 2019-date Fri Dec 20 03:40:33 2019 s - exit: 34304
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_2018 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_2018_MC.root : FAILED - time: date Fri Dec 20 03:55:21 2019-date Fri Dec 20 03:40:38 2019 s - exit: 34304
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Fri Dec 20 03:54:56 2019-date Fri Dec 20 03:40:48 2019 s - exit: 34304
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_PRef_MC.root : FAILED - time: date Fri Dec 20 03:49:21 2019-date Fri Dec 20 03:40:57 2019 s - exit: 34304
cmsDriver.py TTbar_Tauola_8TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_MC.root : FAILED - time: date Fri Dec 20 03:48:30 2019-date Fri Dec 20 03:41:04 2019 s - exit: 34304
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018_pp_on_AA --fileout file:RelVal_Raw_HIon_MC.root : FAILED - time: date Fri Dec 20 03:51:29 2019-date Fri Dec 20 03:41:09 2019 s - exit: 34304
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_MC.root : FAILED - time: date Fri Dec 20 03:48:43 2019-date Fri Dec 20 03:41:12 2019 s - exit: 34304
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_PIon_MC.root : FAILED - time: date Fri Dec 20 03:49:06 2019-date Fri Dec 20 03:41:28 2019 s - exit: 34304

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@smuzaffar
Copy link
Contributor

merging it for Geant4 IBs

@smuzaffar smuzaffar merged commit ddb46eb into cms-sw:IB/CMSSW_11_1_X/geant4 Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants