Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag for RecoTauTag-TrainingFiles to V00-02-00 #5601

Merged

Conversation

cmsbuild
Copy link
Contributor

Move RecoTauTag-TrainingFiles data to new tag, see
cms-data/RecoTauTag-TrainingFiles#4

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor

+externals
it just move the tag to include cms-data/RecoTauTag-TrainingFiles#4

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Feb 26, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4882/console Started: 2020/02/26 10:30

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor Author

-1

Tested at: aca51a5

CMSSW: CMSSW_11_1_X_2020-02-25-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3cbd34/4882/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

>> Entering Package PhysicsTools/TensorFlow
Entering library rule at PhysicsTools/TensorFlow
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-25-2300/src/PhysicsTools/TensorFlow/src/TBBSession.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-25-2300/src/PhysicsTools/TensorFlow/src/TensorFlow.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-25-2300/src/PhysicsTools/TensorFlow/src/NTSession.cc 
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-25-2300/src/PhysicsTools/TensorFlow/src/TBBSession.cc:51:10: fatal error: tensorflow/core/framework/graph.pb_text.h: No such file or directory
 #include "tensorflow/core/framework/graph.pb_text.h"
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-25-2300/src/PhysicsTools/TensorFlow/src/NTSession.cc:49:10: fatal error: tensorflow/core/framework/graph.pb_text.h: No such file or directory
 #include "tensorflow/core/framework/graph.pb_text.h"
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


@cmsbuild
Copy link
Contributor Author

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@mrodozov
Copy link
Contributor

thats ok. this test requires ALSO that the CMSSW TF changes already exists in the IB we are testing against.
The changes were not in the CMSSW_11_1_X_2020-02-25-2300 IB so testing this on it's own against the IB will fail of course. This is a consequence of a feature that says - if a PR was signed but not tested - start the tests. In this case the test also requires other PRs to work.
Bottom line - its fine

@smuzaffar smuzaffar deleted the update-RecoTauTag-TrainingFiles-to-V00-02-00 branch March 6, 2020 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants