Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fireworks-Geometry: download cmsGeom2026 from cmsrep #5713

Merged
merged 2 commits into from Apr 6, 2020

Conversation

smuzaffar
Copy link
Contributor

this should be tested along with cms-data/Fireworks-Geometry#10 and cms-sw/cmssw#29169

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test with cms-data/Fireworks-Geometry#10

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-data/Fireworks-Geometry#10

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29169,cms-data/Fireworks-Geometry#10
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5509/console Started: 2020/04/02 19:21

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

+1
Tested at: 22d6cd3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba373d/5509/summary.html
CMSSW: CMSSW_11_1_X_2020-04-02-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2020

Pull request #5713 was updated.

@silviodonato
Copy link
Contributor

silviodonato commented Apr 4, 2020

can we merge this with cms-sw/cmssw#29169?

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmssw#29169

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29169
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5537/console Started: 2020/04/05 00:08

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2020

+1
Tested at: e3968d2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eaf24d/5537/summary.html
CMSSW: CMSSW_11_1_X_2020-04-04-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2020

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@silviodonato
Copy link
Contributor

@mrodozov @smuzaffar @tulamor is it ready to be merged?

@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2020

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor Author

contains only news data files, so we can safely merge it.

@smuzaffar smuzaffar merged commit fc67f19 into IB/CMSSW_11_1_X/master Apr 6, 2020
@smuzaffar smuzaffar deleted the fireworks-geom branch April 6, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants