make pcms for tinyxml and clhep #5862
Conversation
|
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_11_2_X/rootmodule. @cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks. |
|
@vgvassilev @smuzaffar |
pcm_util.spec
Outdated
|
|
||
| mkdir %{i}/include | ||
| cp clhep.pcm %{i}/include/. | ||
| cp tinyxml2.pcm %{i}/include/. |
There was a problem hiding this comment.
Mostly PCM resides in the lib directory, so I would suggest to copy them to lib directory and use LIBDIR in toolfile too.
@vgvassilev , If I remember correctly, there was some restrictions about having libNAME.so and NAME.pcm in same directory (may be that is only for root dictionaries). So in case of these (clhep and tinyxml) PCMs do we need a library with same name in lib directory?
There was a problem hiding this comment.
No, they should not be connected to any library/dictionary.
There was a problem hiding this comment.
also I think llvm finds PCMs via CLING_PREBUILT_MODULE_PATH ... right @vgvassilev ? I guess we need to set CLING_PREBUILT_MODULE_PATH in toolfile too
There was a problem hiding this comment.
Good point, usually we do. In those particular case tinyxml2 and clhep depend only on libc and std (afaik) which will be loaded by default by rootcling -- we should be safe without that variable I think.
There was a problem hiding this comment.
without the variable how will llvm know about these pcms?
There was a problem hiding this comment.
for cmssw, we set CLING_PREBUILT_MODULE_PATH (pointing to CMSSW_BASE/lib/arch:CMSSW_RELEASE/BASE/lib/arch ) so that already build pcms are visible to clang.
There was a problem hiding this comment.
@smuzaffar - how do I add a PATH like variable to the tool file? Or does scram magically know that this variable is a PATH like variable?
There was a problem hiding this comment.
without the variable how will llvm know about these pcms?
If you mean how rootcling will find libc.pcm and std.pcm -- you are right in that case we need that variable pointing to the location of those.
There was a problem hiding this comment.
@smuzaffar - how do I add a PATH like variable to the tool file? Or does scram magically know that this variable is a PATH like variable?
just like https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_11_2_X/master/clhep-toolfile.spec#L20 i.e. add type="path"
I think you do not need LIBDIR or LD_LIBRARY_PATH for this tool. Just add
<runtime name="CLING_PREBUILT_MODULE_PATH" value="$PCM_UTIL_BASE/lib" type="path"/>
|
Mostly PCM resides in the lib directory, so I would suggest to copy them to lib directory and use LIBDIR in toolfile too.
@vgvassilev<https://github.com/vgvassilev> , If I remember correctly, there was some restrictions about having libNAME.so and NAME.pcm in same directory (may be that is only for root dictionaries). So in case of these (clhep and tinyxml) PCMs do we need a library with same name in lib directory?
Ah - My confusion. I will change to lib. @vgvassilev will have to answer the rest (in which case we may have some circular dependencies to worry about)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#5862 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ5GNJME26YBNNHAVNTRTPAHJANCNFSM4NKJYCZQ>.
|
|
Pull request #5862 was updated. |
|
I pushed changes that should address the feedback. What did I miss? |
pcm_util-toolfile.spec
Outdated
| <tool name="pcm_util" version="@TOOL_VERSION@"> | ||
| <client> | ||
| <environment name="PCM_UTIL_BASE" default="@TOOL_ROOT@"/> | ||
| <runtime name="CLING_PREBUILT_MODULE_PATH" value="$PCM_UTIL_BASE/lib" type="path"/> |
There was a problem hiding this comment.
@davidlange6 this should be outside the <client></client> block :-)
|
Pull request #5862 was updated. |
|
test parameters
|
|
please test |
|
The tests are being triggered in jenkins.
|
|
-1 Tested at: 7a9097d CMSSW: CMSSW_11_2_CXXMODULE_X_2020-05-25-2300 I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: ------- copying files from src/CondCore/DBOutputService/scripts ------- >> copied cmscond_logdb_dump Entering library rule at src/CondCore/DBOutputService/test >> Building edm plugin tmp/slc7_amd64_gcc820/src/CondCore/DBOutputService/test/IOVPayloadEndOfJob/libIOVPayloadEndOfJob.so /cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCondFormatsBeamSpotObjects collect2: error: ld returned 1 exit status gmake: *** [tmp/slc7_amd64_gcc820/src/CondCore/DBOutputService/test/IOVPayloadEndOfJob/libIOVPayloadEndOfJob.so] Error 1 Leaving library rule at src/CondCore/DBOutputService/test Entering library rule at src/CondCore/DBOutputService/test >> Building edm plugin tmp/slc7_amd64_gcc820/src/CondCore/DBOutputService/test/writeBlobComplex/libwriteBlobComplex.so /cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCondFormatsBeamSpotObjects |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
No description provided.