Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade pythia8 to 302 #5869

Merged
merged 2 commits into from Jun 11, 2020
Merged

Conversation

mkirsano
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 27, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6611/console Started: 2020/05/27 08:56

@mkirsano
Copy link
Contributor Author

mkirsano commented May 27, 2020

To be tested together with the PR CMSSW cms-sw/cmssw#29995

@cmsbuild
Copy link
Contributor

-1

Tested at: ffec6ab

  • Build:

I found compilation error when building:

* The action "final-job" was not completed successfully because The following dependencies could not complete:
build-external+geneva+1.0-RC3-7765b8
* The action "install-external+geneva-toolfile+1.0-7765b8" was not completed successfully because The following dependencies could not complete:
build-external+geneva-toolfile+1.0-7765b8
* The action "build-external+geneva+1.0-RC3-7765b8" was not completed successfully because Failed to build geneva. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/geneva/1.0-RC3-7765b8/log. Final lines of the log file:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/geneva/1.0-RC3-7765b8/geneva-1.0-RC3/src/PythiaInterface/PythiaDriver.cpp:488:37: error: no matching function for call to 'Pythia8::Pythia::setUserHooksPtr(Geneva::UserHookRestriction*&)'
_pythia.setUserHooksPtr(_userhook);
^
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/geneva/1.0-RC3-7765b8/geneva-1.0-RC3/include/Geneva/PythiaInterface/PythiaDriver.hpp:28,
from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/geneva/1.0-RC3-7765b8/geneva-1.0-RC3/src/PythiaInterface/PythiaDriver.cpp:23:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/pythia8/302-7765b8/include/Pythia8/Pythia.h:135:8: note: candidate: 'bool Pythia8::Pythia::setUserHooksPtr(Pythia8::UserHooksPtr)'


You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7765b8/6611/summary.html

@smuzaffar
Copy link
Contributor

@mkirsano , looks like geneva failed to build [a] with new pythia8 version

[a]
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7765b8/6611/external/geneva/1.0-RC3-7765b8/log

@mkirsano
Copy link
Contributor Author

The idea is to create a special release for extended tests

@cmsbuild
Copy link
Contributor

Pull request #5869 was updated.

@mkirsano
Copy link
Contributor Author

I finally managed to test geneva build. This test rebuilds openloops, which requires 30 GB of disk space! I confirm that geneva build fails. I suggest to temporarily exclude it for a special release.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29995
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6720/console Started: 2020/06/01 17:46

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2020

+1
Tested at: 574ce6e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3c30f/6720/summary.html
CMSSW: CMSSW_11_2_X_2020-06-01-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3c30f/6720/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 44070 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2782598
  • DQMHistoTests: Total failures: 426577
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 2355965
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -529.394 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.352 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11634.0,... ): -265.416 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 250202.181 ): 0.420 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.666 KiB SiStrip/MechanicalView
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@mkirsano
Copy link
Contributor Author

+1

@smuzaffar
Copy link
Contributor

@mkirsano , so I guess generators are ok with removal of dire, vincia and geneva tools?

@mkirsano
Copy link
Contributor Author

dire and vincia are no more needed, they are included in pythia8. The removal of geneva is temporary, agreed with generators.

@silviodonato
Copy link
Contributor

@smuzaffar is it ready to be merged?

@smuzaffar
Copy link
Contributor

+externals
yes @silviodonato , it is ready to go in along with cms-sw/cmssw#29995

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 386d0f5 into cms-sw:IB/CMSSW_11_2_X/master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants