enable cxxmodules fwcore packages

[smuzaffar]

No description provided.

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_2_X/rootmodule.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[smuzaffar]

test parameters

• full_cmssw = true

[smuzaffar]

please test

[smuzaffar]

@davidlange6 , @vgvassilev this shoudl allow to build CXXMOdules for FWCore/Reflection FWCore/Utilities. I did not add FWCore/Framework FWCore/ParameterSet for now as there are build errors for those

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• BUILD_FULL_CMSSW = true
• CMSSW_11_2_CXXMODULE_X_2020-06-22-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7299/console Started: 2020/06/24 01:08

[cmsbuild]

-1

Tested at: 023b9f6

CMSSW: CMSSW_11_2_CXXMODULE_X_2020-06-22-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e56f42/7299/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found compilation error when building:

Error: Module 'AlignmentCocoaDaq_xr_rdict.pcm' failed to load.
Warning: 'CondFormatsAlignment_xr_rdict.pcm' value is deprecated. Please use []CondFormatsAlignment_xr.pcm
Error: Module 'CondFormatsAlignment_xr_rdict.pcm' failed to load.
gmake: *** [tmp/slc7_amd64_gcc820/src/Alignment/CocoaFit/src/AlignmentCocoaFit/a/AlignmentCocoaFit_xr.cc] Error 1
>> Compiling LCG dictionary: tmp/slc7_amd64_gcc820/src/Alignment/CocoaFit/src/AlignmentCocoaFit/a/AlignmentCocoaFit_xr.cc
c++: error: AlignmentCocoaFit/a/AlignmentCocoaFit_xr.cc: No such file or directory
c++: fatal error: no input files
compilation terminated.
gmake: *** [tmp/slc7_amd64_gcc820/src/Alignment/CocoaFit/src/AlignmentCocoaFit/a/AlignmentCocoaFit_xr.cc.o] Error 1
>> Building  shared library tmp/slc7_amd64_gcc820/src/Alignment/CocoaFit/src/AlignmentCocoaFit/libAlignmentCocoaFit.so
c++: error: tmp/slc7_amd64_gcc820/src/Alignment/CocoaFit/src/AlignmentCocoaFit/a/AlignmentCocoaFit_xr.cc.o: No such file or directory


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[vgvassilev]

@smuzaffar, sounds good!

[davidlange6]

hi @smuzaffar - is there an easy way to reproduce the issues you saw with the other FWCore packages?

[smuzaffar]

Try creating dev area and

• checkout the FW packages
• touch FW/Package/src/classes.h and FW/Package/src/classes_def.xml
• enable CXXMODULES for these FW packages in config/SCRAM/GMAKE/CXXModules.mk file
• scram build

[davidlange6]

Easy! - thanks - @vv is having a look (Of course we know we have local vs full build differences…) On Jun 24, 2020, at 8:57 AM, Malik Shahzad Muzaffar <notifications@github.com<mailto:notifications@github.com>> wrote: Try creating dev area and * checkout the FW packages * touch FW/Package/src/classes.h and FW/Package/src/classes_def.xml * enable CXXMODULES for these FW packages in config/SCRAM/GMAKE/CXXModules.mk file * scram build — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub<#5985 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ6TEAZNRLXSQOFLGRLRYGPXJANCNFSM4OGCNKTQ>.

[vgvassilev]

They work for me:
ls lib/slc7_amd64_gcc820/*pcm
lib/slc7_amd64_gcc820/FWCoreFramework.pcm lib/slc7_amd64_gcc820/FWCoreReflection.pcm
lib/slc7_amd64_gcc820/FWCoreParameterSet.pcm lib/slc7_amd64_gcc820/FWCoreUtilities.pcm

[smuzaffar]

looks good @vgvassilev . For me the full build failed due due to errors in FWCoreFramework and FWCoreParameterSet.
I will open a PR to enable these and run a full build test