[CXXMODULE] new build rules to allow building lcgdict for selected packages #6027

smuzaffar · 2020-07-03T10:36:59Z

No description provided.

…ckages

smuzaffar · 2020-07-03T10:37:14Z

test parameters

full_cmssw = true

cmsbuild · 2020-07-03T10:37:18Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_2_X/rootmodule.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

smuzaffar · 2020-07-03T10:37:19Z

please test

cmsbuild · 2020-07-03T10:37:37Z

The tests are being triggered in jenkins.
Test Parameters:

BUILD_FULL_CMSSW = true
CMSSW_11_2_CXXMODULE_X_2020-07-02-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7641/console Started: 2020/07/03 12:40

cmsbuild · 2020-07-03T11:00:41Z

-1

Tested at: 8e42d49

Build:

I found compilation error when building:

+ chmod -Rf a+rX,u+w,g-w,o-w .
+ cd /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/cms/coral/CORAL_2_3_21-a1a882
+ echo V05-10-20
+ /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/cms/coral/CORAL_2_3_21-a1a882/config/updateConfig.pl -p CORAL -v CORAL_2_3_21-a1a882 -s V2_2_9_pre07 -t /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/cms/coral-tool-conf/2.1-a1a882 -a slc7_amd64_gcc820 --keys SCRAM_COMPILER=gcc --keys PROJECT_GIT_HASH=CORAL_2_3_21
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.H1d8zq: line 58: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/cms/coral/CORAL_2_3_21-a1a882/config/updateConfig.pl: No such file or directory
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.H1d8zq (%prep)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.H1d8zq (%prep)

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1a882/7641/summary.html

smuzaffar · 2020-07-03T11:02:19Z

please test

cmsbuild · 2020-07-03T11:02:36Z

The tests are being triggered in jenkins.
Test Parameters:

BUILD_FULL_CMSSW = true
CMSSW_11_2_CXXMODULE_X_2020-07-02-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7645/console Started: 2020/07/03 13:21

cmsbuild · 2020-07-03T14:31:04Z

-1

Tested at: 8e42d49

CMSSW: CMSSW_11_2_CXXMODULE_X_2020-07-02-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1a882/7645/summary.html

I found follow errors while testing this PR

Failed tests: Build

Build:

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_CXXMODULE_X_2020-07-02-2300/src/Fireworks/TableWidget/src/FWTextTableCellRenderer.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_CXXMODULE_X_2020-07-02-2300/src/Fireworks/TableWidget/src/GlobalContexts.cc
>> Building CXX Module LCG reflex dict from header file tmp/slc7_amd64_gcc820/src/Fireworks/TableWidget/src/FireworksTableWidget/a/FireworksTableWidget_xr.h
In file included from input_line_13:33:
In file included from ./tmp/slc7_amd64_gcc820/src/Fireworks/TableWidget/src/FireworksTableWidget/a/FireworksTableWidget_xr.h:9:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_CXXMODULE_X_2020-07-02-2300/src/Fireworks/TableWidget/interface/FWTextTreeCellRenderer.h:81:7: error: use of undeclared identifier 'gVirtualX'
      gVirtualX->FillRectangle(iID,
      ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_CXXMODULE_X_2020-07-02-2300/src/Fireworks/TableWidget/interface/FWTextTreeCellRenderer.h:108:7: error: use of undeclared identifier 'gVirtualX'
      gVirtualX->FillRectangle(iID,
      ^

cmsbuild · 2020-07-03T14:31:06Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

davidlange6 · 2020-07-03T15:43:11Z

hi @smuzaffar - this error is in the IB. Great news. We are hoping to get a clean build tonight, so I'd prefer to leave this out and do a test on the slide so that we can include this on Monday. I'll report any problems here

mrodozov · 2020-07-03T17:29:19Z

this looks like a missing header (TVirtualX.h)
Or it's something else ?

davidlange6 · 2020-07-03T18:16:45Z

For the moment its a incorrect set of enabled modules. It will be fixed in the 2300 ib. On Jul 3, 2020, at 7:29 PM, Mircho Rodozov <notifications@github.com<mailto:notifications@github.com>> wrote: this looks like a missing header (TVirtualX.h) Or it's something else ? — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#6027 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ4L23YYK5RH4DR7G4LRZYIPXANCNFSM4OPWFRQA>.

davidlange6 · 2020-07-04T16:42:31Z

hi @smuzaffar - I guess rpm is sensitive to ones choice of shell. Mine is happy with

echo '<flags LCGDICT_PACKAGE="$p"/>'  >> config/BuildFile.xml ;\

but is not with what's proposed in this pr

echo "<flags LCGDICT_PACKAGE=\"$p\"/>"  >> config/BuildFile.xml ;\

(I checked the changed syntax on bash and tcsh - both are happy)

cmsbuild · 2020-07-04T18:47:11Z

Pull request #6027 was updated.

smuzaffar · 2020-07-04T18:47:51Z

RPM internally uses /bin/sh. With single quotes it is not going to expand $p. I have updated the PR, we need to escape the \ character too as rpm macro expension removes it.

davidlange6 · 2020-07-05T13:45:58Z

thanks -Indeed, that makes a difference - @vgvassilev

so I get some errors when compiling now.. perhaps the lowest one is

>> Building CXX Module LCG reflex dict from header file tmp/slc7_amd64_gcc820/src/FWCore/ParameterSet/src/FWCoreParameterSet/a/FWCoreParameterSet_xr.h
/build/dlange/200704/slc7_amd64_gcc820/lcg/root/6.23.01-cms/bin/rootcling -reflex -f tmp/slc7_amd64_gcc820/src/FWCore/ParameterSet/src/FWCoreParameterSet/a/FWCoreParameterSet_xr.cc -s tmp/slc7_am\
d64_gcc820/src/FWCore/ParameterSet/src/FWCoreParameterSet/a/libFWCoreParameterSet.so -cxxmodule -failOnWarnings -DCMS_DICT_IMPL -D_REENTRANT -DGNUSOURCE -D__STRICT_ANSI__ -moduleMapFile=/build/dl\
ange/200704/tmp/BUILDROOT/d078707410853c011ddfd317e2416c2b/opt/cmssw/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_CXXMODULE_X_2020-07-03-2300-cms/include/slc7_amd64_gcc820/cxxmodules/module.modulemap -\
DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=80400 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PR\
OVIDER_FORCE_POSIX -DCMSSW_GIT_HASH="CMSSW_11_2_CXXMODULE_X_2020-07-03-2300" -DPROJECT_NAME="CMSSW" -DPROJECT_VERSION="CMSSW_11_2_CXXMODULE_X_2020-07-03-2300-cms" -I/build/dlange/200704/tmp/BUILD\
ROOT/d078707410853c011ddfd317e2416c2b/opt/cmssw/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_CXXMODULE_X_2020-07-03-2300-cms/src -I/build/dlange/200704/slc7_amd64_gcc820/external/pcre/8.43-bcolbf/inclu\
de -isystem/build/dlange/200704/slc7_amd64_gcc820/external/boost/1.72.0-ghbfee/include -I/build/dlange/200704/slc7_amd64_gcc820/external/bz2lib/1.0.6-bcolbf2/include -I/build/dlange/200704/slc7_a\
md64_gcc820/external/libuuid/2.34-bcolbf2/include -isystem/build/dlange/200704/slc7_amd64_gcc820/lcg/root/6.23.01-cms/include -isystem/build/dlange/200704/slc7_amd64_gcc820/external/tbb/2020_U2/i\
nclude -I/build/dlange/200704/slc7_amd64_gcc820/external/xz/5.2.4-bcolbf2/include -I/build/dlange/200704/slc7_amd64_gcc820/external/zlib/1.2.11-bcolbf/include -I/build/dlange/200704/slc7_amd64_gc\
c820/external/md5/1.0.0-bcolbf2/include -I/build/dlange/200704/slc7_amd64_gcc820/external/tinyxml2/6.2.0-ghbfee/include -DCMSSW_REFLEX_DICT tmp/slc7_amd64_gcc820/src/FWCore/ParameterSet/src/FWCor\
eParameterSet/a/FWCoreParameterSet_xr.h tmp/slc7_amd64_gcc820/classes/classes_def.xml
In module 'DataFormatsProvenance' imported from /build/dlange/200704/tmp/BUILDROOT/d078707410853c011ddfd317e2416c2b/opt/cmssw/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_CXXMODULE_X_2020-07-03-2300-cm\
s/src/FWCore/ParameterSet/interface/ParameterSet.h:14:
/build/dlange/200704/slc7_amd64_gcc820/external/tbb/2020_U2/include/tbb/machine/gcc_ia32_common.h:25:24: warning: function '__TBB_machine_lg<unsigned long>' has internal linkage but is not define\
d [-Wundefined-internal]
static inline intptr_t __TBB_machine_lg( T x ) {
                       ^
/build/dlange/200704/slc7_amd64_gcc820/external/tbb/2020_U2/include/tbb/internal/_concurrent_unordered_impl.h:772:46: note: used here
        my_number_of_buckets = size_type(1)<<__TBB_Log2((uintptr_t)n_of_buckets*2-1); // round up to power of 2
                                             ^
/build/dlange/200704/slc7_amd64_gcc820/external/tbb/2020_U2/include/tbb/machine/gcc_ia32_common.h:31:24: note: expanded from macro '__TBB_Log2'
#define __TBB_Log2(V)  __TBB_machine_lg(V)
                       ^

davidlange6 · 2020-07-05T13:58:03Z

@vgvassilev points out that these are warnings - perhaps the error is

'''
/opt/cmssw/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_CXXMODULE_X_2020-07-03-2300-cms/src/FWCore/ParameterSet/interface/defaultModuleLabel.h:8: multiple definition of `edm::defaultModuleLabel(std::__
cxx11::basic_string<char, std::char_traits, std::allocator >)'; tmp/slc7_amd64_gcc820/src/FWCore/ParameterSet/src/FWCoreParameterSet/a/FWCoreParameterSet_xr.cc.o:/opt/cmssw/slc7_amd64
_gcc820/cms/cmssw/CMSSW_11_2_CXXMODULE_X_2020-07-03-2300-cms/src/FWCore/ParameterSet/interface/defaultModuleLabel.h:8: first defined here
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc820/src/FWCore/ParameterSet/src/FWCoreParameterSet/libFWCoreParameterSet.so] Error 1
Leaving library rule at FWCore/ParameterSet
'''

makortel · 2020-07-05T17:23:35Z

Whoops,
https://github.com/cms-sw/cmssw/blob/ecf8a20bd598298e6d3877c5fc3da0e267502897/FWCore/ParameterSet/interface/defaultModuleLabel.h#L8
should have been inline. I'll fix that shortly (actually making the body out-of-line).

makortel · 2020-07-05T17:33:37Z

Should be fixed by cms-sw/cmssw#30543.

davidlange6 · 2020-07-07T12:01:30Z

I've redone the check after Matti's PR has been integrated. The error above is gone. There are more (perhaps not many) - I'll report them if they can be reproduced

makortel · 2020-07-07T12:46:25Z

Thanks David for checking.

cmsbuild · 2020-07-07T20:59:38Z

Pull request #6027 was updated.

cmsbuild · 2020-07-10T06:37:08Z

Pull request #6027 was updated.

davidlange6 · 2020-07-10T06:37:46Z

merging as this all technically works as it should. I will update the list of packages in a followup PR

[CXXMODULE] new build rules to allow building lcgdict for selected pa…

8e42d49

…ckages

cmsbuild added comparison-pending externals-pending orp-pending pending-signatures tests-pending labels Jul 3, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 3, 2020

cmsbuild added tests-rejected and removed tests-started labels Jul 3, 2020

cmsbuild added tests-pending and removed tests-rejected labels Jul 3, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 3, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jul 3, 2020

escape \ char as rpm macro expansion removes it

67dfb64

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Jul 4, 2020

makortel mentioned this pull request Jul 5, 2020

Move edm::defaultModuleLabel() body out-of-line cms-sw/cmssw#30543

Merged

Update scram-project-build.file

ca00d4f

Merge branch 'IB/CMSSW_11_2_X/rootmodule' into extra-cxx-packs

53e47ad

davidlange6 merged commit cb3937e into IB/CMSSW_11_2_X/rootmodule Jul 10, 2020

smuzaffar deleted the extra-cxx-packs branch July 27, 2020 14:43

cmsbuild mentioned this pull request May 17, 2022

[CXXMODULE] Update root module to follow root master branch #7874

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CXXMODULE] new build rules to allow building lcgdict for selected packages #6027

[CXXMODULE] new build rules to allow building lcgdict for selected packages #6027

smuzaffar commented Jul 3, 2020

smuzaffar commented Jul 3, 2020

cmsbuild commented Jul 3, 2020

smuzaffar commented Jul 3, 2020

cmsbuild commented Jul 3, 2020 •

edited

cmsbuild commented Jul 3, 2020

smuzaffar commented Jul 3, 2020

cmsbuild commented Jul 3, 2020 •

edited

cmsbuild commented Jul 3, 2020

cmsbuild commented Jul 3, 2020

davidlange6 commented Jul 3, 2020

mrodozov commented Jul 3, 2020

davidlange6 commented Jul 3, 2020 via email

davidlange6 commented Jul 4, 2020

cmsbuild commented Jul 4, 2020

smuzaffar commented Jul 4, 2020 via email •

edited

davidlange6 commented Jul 5, 2020

davidlange6 commented Jul 5, 2020

makortel commented Jul 5, 2020

makortel commented Jul 5, 2020

davidlange6 commented Jul 7, 2020

makortel commented Jul 7, 2020

cmsbuild commented Jul 7, 2020

cmsbuild commented Jul 10, 2020

davidlange6 commented Jul 10, 2020

[CXXMODULE] new build rules to allow building lcgdict for selected packages #6027

[CXXMODULE] new build rules to allow building lcgdict for selected packages #6027

Conversation

smuzaffar commented Jul 3, 2020

smuzaffar commented Jul 3, 2020

cmsbuild commented Jul 3, 2020

smuzaffar commented Jul 3, 2020

cmsbuild commented Jul 3, 2020 • edited

cmsbuild commented Jul 3, 2020

smuzaffar commented Jul 3, 2020

cmsbuild commented Jul 3, 2020 • edited

cmsbuild commented Jul 3, 2020

cmsbuild commented Jul 3, 2020

davidlange6 commented Jul 3, 2020

mrodozov commented Jul 3, 2020

davidlange6 commented Jul 3, 2020 via email

davidlange6 commented Jul 4, 2020

cmsbuild commented Jul 4, 2020

smuzaffar commented Jul 4, 2020 via email • edited

davidlange6 commented Jul 5, 2020

davidlange6 commented Jul 5, 2020

makortel commented Jul 5, 2020

makortel commented Jul 5, 2020

davidlange6 commented Jul 7, 2020

makortel commented Jul 7, 2020

cmsbuild commented Jul 7, 2020

cmsbuild commented Jul 10, 2020

davidlange6 commented Jul 10, 2020

cmsbuild commented Jul 3, 2020 •

edited

cmsbuild commented Jul 3, 2020 •

edited

smuzaffar commented Jul 4, 2020 via email •

edited