Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[10.6.X] Revert "change to 8240 in to handle high multiplicity bug"" #6186

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

qliphy
Copy link
Contributor

@qliphy qliphy commented Aug 21, 2020

Reverts #6041, to move back to Pythia8240 with bug fix, as required by PPD (@srimanob)

cc: @SiewYan, @mkirsano @GurpreetSinghChahal @agrohsje @alberto-sanchez

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @qliphy (Qiang Li) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@qliphy
Copy link
Contributor Author

qliphy commented Aug 21, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 21, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 0d57494
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-159b54/8844/summary.html
CMSSW: CMSSW_10_6_X_2020-08-20-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@davidlange6
Copy link
Contributor

how is the master being managed here?

@srimanob
Copy link

Hi @davidlange6
Master is on the newer version of Pythia already (8.243), so no change in master.
This is to keep 8.240 in Legacy release with bug fix.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-159b54/8844/summary.html

Comparison Summary:

  • You potentially added 743 lines to the logs
  • Reco comparison results: 41310 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214614
  • DQMHistoTests: Total failures: 417099
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 2797178
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -24.974 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.786 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 10824.0,... ): -12.992 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 250202.181 ): 0.225 KiB SiStrip/MechanicalView
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@qliphy
Copy link
Contributor Author

qliphy commented Aug 21, 2020

as expected the comparison result is opposite to #6041

@qliphy
Copy link
Contributor Author

qliphy commented Aug 21, 2020

+1

@qliphy
Copy link
Contributor Author

qliphy commented Aug 21, 2020

merge

@cmsbuild cmsbuild merged commit 6d60beb into IB/CMSSW_10_6_X/gcc700 Aug 21, 2020
@smuzaffar smuzaffar deleted the revert-6041-smuzaffar-patch-5 branch September 2, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants