Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tag for CalibPPS-ESProducers to V01-03-00 (10_6 backport) #6303

Merged
merged 1 commit into from Oct 28, 2020
Merged

Update tag for CalibPPS-ESProducers to V01-03-00 (10_6 backport) #6303

merged 1 commit into from Oct 28, 2020

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Oct 12, 2020 •
edited

10_6 backport of #6302
the request for backport: (with the data PR link):
cms-data/CalibPPS-ESProducers#4 (comment)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

please test
although its just a new file

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 12, 2020 •
edited

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: b77fb0f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-817a2d/9881/summary.html
CMSSW: CMSSW_10_6_X_2020-10-11-2300
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-817a2d/9881/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214663
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214327
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@mrodozov
Copy link
Contributor Author

+externals
looks ok to me

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

@mrodozov , which PR it is back porting? Can you please add the ref here?

@mrodozov
Copy link
Contributor Author

mrodozov commented Oct 21, 2020 •
edited

the description was updated

@mrodozov mrodozov changed the title Update tag for CalibPPS-ESProducers to V01-03-00 Update tag for CalibPPS-ESProducers to V01-03-00 (10_6 backport) Oct 21, 2020
@silviodonato
Copy link
Contributor

fyi @jan-kaspar

@jan-kaspar
Copy link

Many thanks @silviodonato !

@mrodozov mrodozov merged commit 91e0720 into IB/CMSSW_10_6_X/gcc700 Oct 28, 2020
@smuzaffar smuzaffar deleted the backport-6302-to-106 branch November 4, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available externals-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mrodozov @cmsbuild @smuzaffar @silviodonato @jan-kaspar