Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rivet 3.1.3 and YODA 1.8.5 (11_2_X) #6483

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

mseidel42
Copy link
Contributor

Builds and runs in CMSSW_11_2_0_pre11. Would be nice to get into 11_2_0, as some bugs in plotting tools seem to be fixed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2020

A new Pull Request was created by @intrepid42 (Markus Seidel) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor

mrodozov commented Dec 4, 2020

allow @intrepid42 test rights

@smuzaffar
Copy link
Contributor

@intrepid42 , this should first go in 11.3.X, can you please open a PR for IB/CMSSW_11_3_X/master ?

@mseidel42
Copy link
Contributor Author

@intrepid42 , this should first go in 11.3.X, can you please open a PR for IB/CMSSW_11_3_X/master ?

Ok, sure! #6485

@mseidel42 mseidel42 changed the title Rivet 3.1.3 and YODA 1.8.5 Rivet 3.1.3 and YODA 1.8.5 (11_2_X) Dec 6, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2020

Pull request #6483 was updated.

@mseidel42
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2020

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f18c3/11416/summary.html
CMSSW: CMSSW_11_2_X_2020-12-07-2300
SCRAM_ARCH: slc7_amd64_gcc900

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2020

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f18c3/11416/summary.html
CMSSW: CMSSW_11_2_X_2020-12-07-2300
SCRAM_ARCH: slc7_amd64_gcc900

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529593
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529564
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 37 edm output root files, 35 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 479d861 into cms-sw:IB/CMSSW_11_2_X/master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants