Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCRAM] Fixes for recursive scram build #6864

Merged
merged 2 commits into from May 3, 2021

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar
Copy link
Contributor Author

test parameters:

  • addpkg = FWCore

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2021

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2021

Pull request #6864 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@mrodozov
Copy link
Contributor

mrodozov commented May 3, 2021

@smuzaffar there was one unit test failing for arm and ppc (import-yaml) that is not failing anymore (which is fine of course)
could it have been because of scram update ? now it's not failing but it just miraculously disappeared

last it was showing that it's searching for yaml from the jenkins-env:


===== Test "import-yaml" ====
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/shared/yaml/__init__.py", line 2, in <module>
    from error import *
ModuleNotFoundError: No module named 'error'


@smuzaffar
Copy link
Contributor Author

I think it was failing because it was picking up yaml from /cvmfs/cms-ib.cern.ch/jenkins-env/python/shared which was wrong and we should start cleaning up /cvmfs/cms-ib.cern.ch/jenkins-env .

and yes it is fixed due to new SCRAM as new SCRAM remove PYTHONPATH before running any scram command . This means for "scram build runtests" the PYTHONPATH is unset and that is why /cvmfs/cms-ib.cern.ch/jenkins-env/python/shared is not seen by python

@smuzaffar smuzaffar merged commit b22de09 into IB/CMSSW_12_0_X/master May 3, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-209872/14795/summary.html
COMMIT: e33b239
CMSSW: CMSSW_12_0_X_2021-05-02-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6864/14795/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
312.0 step 1
25202.0 step 2
10224.0 step 2
250202.181 step 2
34834.999 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 107 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 17
  • DQMHistoTests: Total histograms compared: 1625174
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1625163
  • DQMHistoTests: Total skipped: 10
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 16 files compared)
  • Checked 96 log files, 4 edm output root files, 17 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants