Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libunwind dependency on zlib. #6873

Merged

Conversation

gartung
Copy link
Member

@gartung gartung commented May 4, 2021

Changes between libunwind v1.4 and v1.5
libunwind/libunwind@v1.4.0...v1.5
may include a dependency on libz.so.
Since we use our own libz.so libunwind.so should be linked against it.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2021

A new Pull Request was created by @gartung (Patrick Gartung) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented May 4, 2021

please test

@gartung
Copy link
Member Author

gartung commented May 4, 2021

abort

@gartung gartung changed the title Revert libunwind to v1.4.0 Add libunwind dependency on zlib. May 4, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2021

Pull request #6873 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2021

Pull request #6873 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2021

Pull request #6873 was updated.

@gartung
Copy link
Member Author

gartung commented May 4, 2021

enable profiling

@gartung
Copy link
Member Author

gartung commented May 4, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2021

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc878b/14855/summary.html
COMMIT: 6163d1c
CMSSW: CMSSW_12_0_X_2021-05-04-1100/slc7_amd64_gcc900
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6873/14855/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc878b/14855/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc878b/14855/git-merge-result

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-04-1100/src/SimG4Core/Physics/src/PhysicsList.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-04-1100/src/SimG4Core/Physics/src/PhysicsListFactory.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-04-1100/src/FWCore/PluginManager/interface/PluginFactory.h:27,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-04-1100/src/SimG4Core/Physics/interface/PhysicsListFactory.h:7,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-04-1100/src/SimG4Core/Physics/src/PhysicsListFactory.cc:1:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-04-1100/src/FWCore/PluginManager/interface/PluginFactoryBase.h:64:58: error: 'zero_allocator' is not a member of 'tbb'
   64 |     typedef tbb::concurrent_vector> PMakers;
      |                                                          ^~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-04-1100/src/FWCore/PluginManager/interface/PluginFactoryBase.h:64:73: error: template argument 2 is invalid
   64 |     typedef tbb::concurrent_vector> PMakers;
      |                                                                         ^~~~~~~~~~~~~~~


@mrodozov
Copy link
Contributor

mrodozov commented May 5, 2021

please test
the last IB will have cms-sw/cmssw#33474

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc878b/14872/summary.html
COMMIT: 6163d1c
CMSSW: CMSSW_12_0_X_2021-05-04-2300/slc7_amd64_gcc900
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6873/14872/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2662646
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2662617
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2021

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@gartung gartung deleted the gartung-revert-libunwind branch May 5, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants