-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libunwind dependency on zlib. #6873
Add libunwind dependency on zlib. #6873
Conversation
A new Pull Request was created by @gartung (Patrick Gartung) for branch IB/CMSSW_12_0_X/master. @cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks. |
please test |
abort |
675e3fc
to
639a3c6
Compare
Pull request #6873 was updated. |
639a3c6
to
82e3509
Compare
Pull request #6873 was updated. |
Pull request #6873 was updated. |
enable profiling |
please test |
-1 Failed Tests: Build The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-04-1100/src/SimG4Core/Physics/src/PhysicsList.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-04-1100/src/SimG4Core/Physics/src/PhysicsListFactory.cc In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-04-1100/src/FWCore/PluginManager/interface/PluginFactory.h:27, from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-04-1100/src/SimG4Core/Physics/interface/PhysicsListFactory.h:7, from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-04-1100/src/SimG4Core/Physics/src/PhysicsListFactory.cc:1: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-04-1100/src/FWCore/PluginManager/interface/PluginFactoryBase.h:64:58: error: 'zero_allocator' is not a member of 'tbb' 64 | typedef tbb::concurrent_vector> PMakers; | ^~~~~~~~~~~~~~ /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-04-1100/src/FWCore/PluginManager/interface/PluginFactoryBase.h:64:73: error: template argument 2 is invalid 64 | typedef tbb::concurrent_vector> PMakers; | ^~~~~~~~~~~~~~~ |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc878b/14872/summary.html Comparison SummarySummary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
Changes between libunwind v1.4 and v1.5
libunwind/libunwind@v1.4.0...v1.5
may include a dependency on libz.so.
Since we use our own libz.so libunwind.so should be linked against it.