PPC - remove -mlong-double-64 flag and use the default #6933

mrodozov · 2021-05-22T01:09:09Z

Compiling externals with the -mlong-double-64 makes their long double types to have only 64 bits size when cmssw long double vars remain 128 using the defaults.
In this case cmssw 128 bits var were passed to clhep compiled with -mlong-double-64

cmsbuild · 2021-05-22T01:09:29Z

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

mrodozov · 2021-05-22T01:09:32Z

please test

cmsbuild · 2021-05-22T11:02:39Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d0525/15249/summary.html
COMMIT: a290a82
CMSSW: CMSSW_12_0_X_2021-05-21-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6933/15249/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2650486
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2650457
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

mrodozov · 2021-05-22T12:23:40Z

please test

mrodozov · 2021-05-22T12:27:42Z

test parameters:

release/arch = CMSSW_12_0_X_2021-05-21-2300/slc7_ppc64le_gcc9
full_cmssw = true

mrodozov · 2021-05-22T12:28:05Z

please test

cmsbuild · 2021-05-22T19:14:38Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d0525/15255/summary.html
COMMIT: a290a82
CMSSW: CMSSW_12_0_X_2021-05-21-2300/slc7_ppc64le_gcc9
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6933/15255/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

                 from /scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-21-2300/src/DataFormats/GeometryVector/interface/Phi.h:5,
                 from /scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-21-2300/src/DataFormats/GeometryVector/test/PhiTest.cc:1:
/scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-21-2300/src/DataFormats/GeometryVector/test/PhiTest.cc: In instantiation of 'int testSmall() [with valType = float]':
/scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-21-2300/src/DataFormats/GeometryVector/test/PhiTest.cc:172:24:   required from here
/scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-21-2300/src/DataFormats/GeometryVector/test/PhiTest.cc:39:31:   in 'constexpr' expansion of 'angle_units::operators::operator""_pi(1.52999e+1l)'
/scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-21-2300/src/DataFormats/Math/interface/angle_units.h:14:63: error: '(1.52999e+1l * 3.14159265358979311599796346854419e+0l)' is not a constant expression
   14 |     constexpr double operator"" _pi(long double x) { return x * piRadians; }
      |                                                             ~~^~~~~~~~~~~
/scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-21-2300/src/DataFormats/GeometryVector/test/PhiTest.cc: In instantiation of 'int testSmall() [with valType = double]':
/scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-21-2300/src/DataFormats/GeometryVector/test/PhiTest.cc:175:25:   required from here
/scratch/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-21-2300/src/DataFormats/GeometryVector/test/PhiTest.cc:39:31:   in 'constexpr' expansion of 'angle_units::operators::operator""_pi(1.52999e+1l)'

mrodozov · 2021-05-29T15:06:40Z

please test with cms-sw/cmssw#33892

cmsbuild · 2021-05-29T15:06:46Z

Pull request #6933 was updated.

mrodozov · 2021-05-29T15:06:55Z

abort

cmsbuild · 2021-06-01T04:22:04Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d0525/15488/summary.html
COMMIT: ed293b8
CMSSW: CMSSW_12_0_X_2021-05-30-2300/slc7_ppc64le_gcc9
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6933/15488/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Update cmssw-wm-tools.spec with fix to Tier0 interface #6950 @cms-sw: Update cmssw-wm-tools.spec with fix to Tier0 interface

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d0525/15488/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d0525/15488/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test_PrepareInputDb had ERRORS
---> test test_MpsWorkFlow had ERRORS
---> test DFM_Math had ERRORS
---> test testFWCoreUtilities had ERRORS
and more ...

mrodozov · 2021-06-02T10:09:58Z

@smuzaffar cms-sw/cmssw#33892 is merged now we can get this one for the evening IB

smuzaffar · 2021-06-02T10:19:13Z

@mrodozov , I would like to test OpenBlas change separately to see if that works for SKYLAKEAVX512_X IBs. Can you please just make a PR with only OpenBLAS update?

cmsbuild · 2021-06-02T10:52:53Z

Pull request #6933 was updated.

mrodozov · 2021-06-02T13:26:47Z

I remove the openblas changes. get it as it is ?

smuzaffar · 2021-06-02T18:11:55Z

please test for slc7_ppc64le_gcc9
lets run tests again ( just to make sure there is no typo)

cmsbuild · 2021-06-03T04:27:13Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d0525/15566/summary.html
COMMIT: bbde15b
CMSSW: CMSSW_12_0_X_2021-06-01-2300/slc7_ppc64le_gcc9
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6933/15566/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Update tag for RecoJets-JetProducers to V05-14-00 #6961 @cms-sw: Update tag for RecoJets-JetProducers to V05-14-00
dropping more python2 tools #6955 @davidlange6: dropping more python2 tools
adding ppjjjj openloop library #6956 @SiewYan: adding ppjjjj openloop library

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d0525/15566/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d0525/15566/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test_PrepareInputDb had ERRORS
---> test test_MpsWorkFlow had ERRORS
---> test DFM_Math had ERRORS
---> test DFM_MathRepr had ERRORS
and more ...

smuzaffar · 2021-06-03T05:57:56Z

+externals
looks good

cmsbuild · 2021-06-03T05:58:13Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild added externals-pending orp-pending pending-signatures tests-pending labels May 22, 2021

cmsbuild added tests-started and removed tests-pending labels May 22, 2021

cmsbuild added tests-approved and removed tests-started labels May 22, 2021

cmsbuild added tests-pending and removed tests-approved labels May 22, 2021

cmsbuild added tests-approved and removed tests-pending labels May 22, 2021

mrodozov mentioned this pull request May 22, 2021

understand long double behaviour on PPC cms-sw/cmssw#33743

Closed

Update ppc build flags and rpm macro

7b46b26

mrodozov force-pushed the remove-longdouble-64-flag branch from a290a82 to 7b46b26 Compare May 29, 2021 15:06

cmsbuild added requires-external tests-started and removed tests-approved labels May 29, 2021

cmsbuild added tests-pending and removed tests-started labels May 29, 2021

cmsbuild added tests-started and removed tests-pending labels May 31, 2021

cmsbuild added tests-rejected and removed tests-started labels Jun 1, 2021

revert the openblas change

bbde15b

cmsbuild added tests-pending and removed tests-rejected labels Jun 2, 2021

mrodozov mentioned this pull request Jun 2, 2021

Update OpenBLAS to 0.3.15 #6963

Merged

cmsbuild added tests-started and removed tests-pending labels Jun 2, 2021

cmsbuild added tests-rejected and removed tests-started labels Jun 3, 2021

smuzaffar merged commit d3b6a61 into IB/CMSSW_12_0_X/master Jun 3, 2021

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Jun 3, 2021

This was referenced Jun 3, 2021

Update LLVM to 12.0 #6890

Merged

drop root_numpy and root_pandas deps #6972

Merged

Update vecgeom to 1.1.16 #6975

Merged

smuzaffar deleted the remove-longdouble-64-flag branch June 10, 2021 20:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PPC - remove -mlong-double-64 flag and use the default #6933

PPC - remove -mlong-double-64 flag and use the default #6933

mrodozov commented May 22, 2021

cmsbuild commented May 22, 2021

mrodozov commented May 22, 2021

cmsbuild commented May 22, 2021

mrodozov commented May 22, 2021

mrodozov commented May 22, 2021

mrodozov commented May 22, 2021

cmsbuild commented May 22, 2021

mrodozov commented May 29, 2021

cmsbuild commented May 29, 2021

mrodozov commented May 29, 2021

cmsbuild commented Jun 1, 2021

mrodozov commented Jun 2, 2021 •

edited

smuzaffar commented Jun 2, 2021

cmsbuild commented Jun 2, 2021

mrodozov commented Jun 2, 2021 •

edited

smuzaffar commented Jun 2, 2021

cmsbuild commented Jun 3, 2021

smuzaffar commented Jun 3, 2021

cmsbuild commented Jun 3, 2021

PPC - remove -mlong-double-64 flag and use the default #6933

PPC - remove -mlong-double-64 flag and use the default #6933

Conversation

mrodozov commented May 22, 2021

cmsbuild commented May 22, 2021

mrodozov commented May 22, 2021

cmsbuild commented May 22, 2021

Comparison Summary

mrodozov commented May 22, 2021

mrodozov commented May 22, 2021

mrodozov commented May 22, 2021

cmsbuild commented May 22, 2021

Build

mrodozov commented May 29, 2021

cmsbuild commented May 29, 2021

mrodozov commented May 29, 2021

cmsbuild commented Jun 1, 2021

Unit Tests

mrodozov commented Jun 2, 2021 • edited

smuzaffar commented Jun 2, 2021

cmsbuild commented Jun 2, 2021

mrodozov commented Jun 2, 2021 • edited

smuzaffar commented Jun 2, 2021

cmsbuild commented Jun 3, 2021

Unit Tests

smuzaffar commented Jun 3, 2021

cmsbuild commented Jun 3, 2021

mrodozov commented Jun 2, 2021 •

edited

mrodozov commented Jun 2, 2021 •

edited