[TBB] Commit in master suggested by TBB devs

[mrodozov]

See cms-sw/cmssw#33636 (comment)
this is building. it's not a tag but we need this change (hopefully it fixes our issue)

[mrodozov]

please test

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_12_0_X/master.

@smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

[makortel]

Would it make sense to test this first in non-production IBs? I suppose ARM and PPC would make most sense.

I'm a bit concerned of updating the production IB to a non-release version. At minimum, I think, this should not be merged for production IB before pre3 is cut.

[mrodozov]

after the test we can

1. merge it
2. build 1 devel 1 ppc and 1 arm IB
3. revert it until we are sure it's ok for master (and TBB people make a new tag maybe)

[makortel]

The crashes in PPC seem to be frequent-enough that a single IB could be sufficient to check if the crashes get fixed.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a2460/16003/summary.html
COMMIT: 32df3e9
CMSSW: CMSSW_12_0_X_2021-06-16-0900/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7035/16003/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• moving new, tested crab-dev to prod for SL6 compat #7032 @belforte: moving new, tested crab-dev to prod for SL6 compat
• Update buildrule and scram #7033 @cms-sw: Update buildrule and scram

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a2460/16003/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a2460/16003/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2862520
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2862491
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[mrodozov]

right, I noticed the IB failed and then went to see what wrong:
https://github.com/oneapi-src/oneTBB/blob/8b6f831c68170231ad2748962d48e7d279d35084/src/tbbmalloc/frontend.cpp#L806-L819
I'm asking the tbb devs what to do because improvising can make things worse 😅
In short there is no ppc block and the compiler skips that part failing to compile when meets getSmallObjectIndex