New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving externals towards python3 #7070
Moving externals towards python3 #7070
Conversation
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_12_0_X/master. @cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks. |
Pull request #7070 was updated. |
please test |
scons-toolfile.spec
Outdated
@@ -1,5 +1,5 @@ | |||
### RPM external scons-toolfile 2.0 | |||
Requires: scons | |||
Requires: py3-scons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidlange6 , this will fail to find TOOL_ROOT
. Please rename scons-toolfile.spec
to py3-scons-toolfile.spec
so that https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_12_0_X/master/scram-tools-post.file#L4 can properly find the TOOL_ROOT
. Note that the xml file generated inside the py3-scons-toolfile.spec
can remain the same.
Ah - right! - will do but I’ll see what else fails first..
… On Jun 28, 2021, at 5:56 PM, Malik Shahzad Muzaffar ***@***.***> wrote:
@smuzaffar commented on this pull request.
In scons-toolfile.spec:
> @@ -1,5 +1,5 @@
### RPM external scons-toolfile 2.0
-Requires: scons
+Requires: py3-scons
@davidlange6 , this will fail to find TOOL_ROOT. Please rename scons-toolfile.spec to py3-scons-toolfile.spec so that https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_12_0_X/master/scram-tools-post.file#L4 can properly find the TOOL_ROOT . Note that the xml file generated inside the py3-scons-toolfile.spec can remain the same.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fff395/16286/summary.html External BuildI found compilation warning when building: See details on the summary page. |
pip/requirements.txt
Outdated
@@ -220,6 +220,7 @@ pyparsing==2.4.7; python_version>'3.0' | |||
pyrsistent==0.17.3 ; python_version>'3.0' | |||
py==1.10.0; python_version>'3.0' | |||
pydantic==1.8.2 ; python_version>'3.0' | |||
pygithub==1.5.5 ; python_version>'3.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidlange6 , this should be 1.55
Pull request #7070 was updated. |
please test |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fff395/16293/summary.html External BuildI found compilation warning when building: See details on the summary page. |
Pull request #7070 was updated. |
please test |
please test for slc7_aarch64_gcc9 |
please test for CMSSW_12_0_X/slc7_ppc64le_gcc9 |
please test |
Pull request #7070 was updated. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fff395/16324/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fff395/16330/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
Move scons to python3
move several py2*spec files to py3 and pip
remove python2 from Yoda
add open loops patch (modified) from Shahzad