-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade pythia8 to 306 #7116
Upgrade pythia8 to 306 #7116
Conversation
A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for branch IB/CMSSW_12_0_X/master. @cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7adc73/16614/summary.html Comparison SummarySummary:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7adc73/16664/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7adc73/16690/summary.html Comparison SummarySummary:
|
assign generators @cms-sw/generators-l2 there are a lot of comparison differences with |
New categories assigned: generators,reconstruction @mkirsano,@SiewYan,@alberto-sanchez,@agrohsje,@GurpreetSinghChahal you have been requested to review this Pull request/Issue and eventually sign? Thanks |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7adc73/16765/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
I think it is normal to have many small differences for a new pythia8
version
In my tests, I don't see big differences this time.
14/07/21 01:55, cmsbuild пишет:
…
+1
*Summary*:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7adc73/16765/summary.html
<https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7adc73/16765/summary.html>
*COMMIT*: bcee512
<bcee512>
*CMSSW*: CMSSW_12_0_X_2021-07-12-2300/slc7_amd64_gcc900
*User test area*: For local testing, you can use
|/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7116/16765/install.sh| to
create a dev area with all the needed externals and cmssw changes.
The following merge commits were also included on top of IB + this PR
after doing git cms-merge-topic:
* @cms-sw <https://github.com/cms-sw> #7125
<#7125>
* @mkirsano <https://github.com/mkirsano> #7122
<#7122>
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7adc73/16765/git-recent-commits.json
<https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7adc73/16765/git-recent-commits.json>
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7adc73/16765/git-merge-result
<https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7adc73/16765/git-merge-result>
Comparison Summary
*Summary*:
* No significant changes to the logs found
* Reco comparison results: 52376 differences found in the comparisons
* DQMHistoTests: Total files compared: 38
* DQMHistoTests: Total histograms compared: 2786302
* DQMHistoTests: Total failures: 374074
* DQMHistoTests: Total nulls: 281
* DQMHistoTests: Total successes: 2411925
* DQMHistoTests: Total skipped: 22
* DQMHistoTests: Total Missing objects: 0
* DQMHistoSizes: Histogram memory added: 0.755 KiB( 37 files compared)
* DQMHistoSizes: changed ( 10224.0 ): 0.659 KiB SiStrip/MechanicalView
* DQMHistoSizes: changed ( 250202.181 ): 0.229 KiB
SiStrip/MechanicalView
* DQMHistoSizes: changed ( 25202.0 ): -0.133 KiB SiStrip/MechanicalView
* Checked 160 log files, 37 edm output root files, 38 DQM output files
* TriggerResults
<https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_0_X_2021-07-12-2300+7adc73/44059/triggerResults>:
found differences in 11 / 37 workflows
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7116 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGOJUXFOZIHQDQ6LJPFLBTTXTG5TANCNFSM5ABCPUIA>.
|
if this is ok then @cms-sw/generators-l2 can you please sign this ? |
+1 |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
@qliphy , @silviodonato @perrotta any objection on mergign pythia8 version 306 for 12.0.X ? |
@smuzaffar I am fine to merge this. |
lets merge it then. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7adc73/17922/summary.html Comparison SummarySummary:
|
Hi @mtosi. Tests look good. Do you have any news on the tracking particle eta in ttbar? |
No description provided.