Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the NVIDIA GDRCopy library to version 2.2 #7168

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jul 25, 2021

Add support for ARM64.

See https://github.com/NVIDIA/gdrcopy/releases/tag/v2.2 for more details.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 25, 2021

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_12_0_X/master.

@smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.
cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 25, 2021

please test for slc7_aarch64_gcc9

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 25, 2021

please test for slc7_ppc64le_gcc9

@fwyzard fwyzard force-pushed the IB/CMSSW_12_0_X/master_gdrcopy_v22 branch from cd8a6e1 to 7561369 Compare July 26, 2021 03:27
@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 26, 2021

please test for slc7_aarch64_gcc9

@cmsbuild
Copy link
Contributor

Pull request #7168 was updated.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 26, 2021

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 26, 2021

please test for CMSSW_12_0_X/slc7_ppc64le_gcc9

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73ca55/17190/summary.html
COMMIT: 7561369
CMSSW: CMSSW_12_0_X_2021-07-25-2300/slc7_ppc64le_gcc9
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7168/17190/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test_PrepareInputDb had ERRORS
---> test test_MpsWorkFlow had ERRORS
---> test testFWCoreUtilities had ERRORS
---> test testHeterogeneousCoreCUDACore had ERRORS
and more ...

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73ca55/17191/summary.html
COMMIT: 7561369
CMSSW: CMSSW_12_0_X_2021-07-25-2300/slc7_aarch64_gcc9
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7168/17191/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testFWCoreConcurrency had ERRORS
---> test testFWCoreUtilities had ERRORS
---> test TestFWCoreServicesDriver had ERRORS
---> test testUploadConditions had ERRORS
and more ...

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73ca55/17189/summary.html
COMMIT: 7561369
CMSSW: CMSSW_12_0_X_2021-07-25-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7168/17189/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test materialBudgetTrackerPlots had ERRORS
---> test materialBudgetHGCalPlots had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998535
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 26, 2021

@smuzaffar these errors look quite random, and unrelated to these changes; are there any problems with the IBs ? or should I try to reproduce and look into them ?

@smuzaffar
Copy link
Contributor

@fwyzard , all of these unit tests are failing in IBs too.

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 9ec2c8c into cms-sw:IB/CMSSW_12_0_X/master Jul 26, 2021
@fwyzard fwyzard deleted the IB/CMSSW_12_0_X/master_gdrcopy_v22 branch April 1, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants