Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated correctionlib version 2.0.0 and its dependencies #7301

Merged
merged 4 commits into from Sep 14, 2021

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Sep 13, 2021

fixes #7300

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_1_X/master.

@smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar smuzaffar changed the title Correctionlib 200 Updated correctionlib version 2.0.0 and its dependencies Sep 13, 2021
@nsmith-
Copy link

nsmith- commented Sep 13, 2021

Is it possible to also populate a scram tool with the C++ binding location, e.g. via cms-nanoAOD/correctionlib#86 (comment)

@smuzaffar
Copy link
Contributor Author

sure, I will add the toolfile

@cmsbuild
Copy link
Contributor

Pull request #7301 was updated.

@smuzaffar
Copy link
Contributor Author

@nsmith- , ok I have added the scram toolfile and now it should be possible to do <use name="correctionlib"/> to link against libcorrectionlib . Do you have any simple example or unit test which we can add in cmssw to test it along with this PR?

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #7301 was updated.

@smuzaffar
Copy link
Contributor Author

+externals
unit tests passed.

@smuzaffar smuzaffar merged commit c1cd025 into IB/CMSSW_12_1_X/master Sep 14, 2021
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_1_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbbfac/18576/summary.html
COMMIT: 7a2b42a
CMSSW: CMSSW_12_1_X_2021-09-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7301/18576/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3001001
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3000973
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@nsmith-
Copy link

nsmith- commented Sep 14, 2021

Do you have any simple example or unit test which we can add in cmssw to test it along with this PR?

I will try to put something together today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update correctionlib to v2.0
3 participants