Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mkFit release for CMSSW_12_2_0_pre3 #7465

Merged

Conversation

mmasciov
Copy link
Contributor

@mmasciov mmasciov commented Nov 25, 2021

https://github.com/trackreco/mkFit/releases/tag/V3.5.3-0%2Bpr388

Related to cms-sw/cmssw#36246 and cms-data/RecoTracker-MkFit#8.

Note: this PR was update on November 28th, following a technical update in mkFit (with a new mkFit release), that allowed to obtain a further speedup with no change in physics.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmasciov (Mario Masciovecchio) for branch IB/CMSSW_12_2_X/master.

@cmsbuild, @smuzaffar, @iarspider, @ddaina can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #7465 was updated.

@perrotta
Copy link
Contributor

+1

  • Needed by #36246

@perrotta
Copy link
Contributor

@smuzaffar , this must have already been tested together with #36246, see cms-sw/cmssw#36246 (comment)
I don't know why it does not look as "tested", but perhaps we can avoid wating for the end of the tests started right now (which will likely fail, since they miss the needed accompanying PRs) and just merge. Otherwise next IB will be broken.

@smuzaffar
Copy link
Contributor

this has been tested and cms-sw/cmssw#36246 which needs it has already been merged. so i am merging this too

@smuzaffar smuzaffar merged commit aa77010 into cms-sw:IB/CMSSW_12_2_X/master Nov 30, 2021
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d525f/20875/summary.html
COMMIT: 5d96733
CMSSW: CMSSW_12_2_X_2021-11-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7465/20875/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11526 differences found in the comparisons
  • DQMHistoTests: Total files compared: 41
  • DQMHistoTests: Total histograms compared: 3042214
  • DQMHistoTests: Total failures: 17146
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3025046
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
  • Checked 175 log files, 37 edm output root files, 41 DQM output files
  • TriggerResults: no differences found

cmsbuild added a commit that referenced this pull request Dec 3, 2021
[12.1.X] Update of mkFit release and configuration (backport of PRs #7465 + #7481)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants