Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dasgoclient version #7646

Merged
merged 1 commit into from Feb 24, 2022
Merged

New dasgoclient version #7646

merged 1 commit into from Feb 24, 2022

Conversation

vkuznet
Copy link
Contributor

@vkuznet vkuznet commented Feb 24, 2022

It contains fix for file dataset=XXX run=123 lumi=098 query based on recent transition of DBS server

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vkuznet (Valentin Kuznetsov) for branch IB/CMSSW_12_3_X/master.

@cmsbuild, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

test parameters:

  • addpkg = PhysicsTools/Utilities

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99c848/22649/summary.html
COMMIT: b34fa1b
CMSSW: CMSSW_12_3_X_2022-02-23-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7646/22649/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@smuzaffar
Copy link
Contributor

@vkuznet , it failed to get the sources

Error while downloading https://github.com/dmwm/dasgoclient/releases/download/v02.04.40/dasgoclient_aarch64: HTTP Error 504: Gateway Time-out
Error while downloading https://github.com/dmwm/dasgoclient/releases/download/v02.04.40/dasgoclient_amd64: HTTP Error 504: Gateway Time-out

can you please check if dasgoclient binaries are already available?

@vkuznet
Copy link
Contributor Author

vkuznet commented Feb 24, 2022

yes, they are there, see https://github.com/dmwm/dasgoclient/releases/tag/v02.04.40, and I can get them with curl. I think it was a network glitch. Please restart the test.

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_3_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99c848/22650/summary.html
COMMIT: b34fa1b
CMSSW: CMSSW_12_3_X_2022-02-23-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7646/22650/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99c848/22650/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99c848/22650/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test_edmPickEvents had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 4001143
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 4001107
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants