Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10_6] Backport Pythia fix for alphaS running #8555

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

mseidel42
Copy link
Contributor

Activate backported fixes for alphaS running cms-externals/pythia8#30

Activate backported fixes for alphaS running
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 20, 2023

A new Pull Request was created by @mseidel42 (Markus Seidel) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@mseidel42 mseidel42 changed the title Update pythia8.spec [10_6] Backport Pythia fix for alphaS running Jun 20, 2023
@rappoccio
Copy link

hold

  • Hold this until decision comes from PPD to approve this backport.

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @rappoccio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Jun 20, 2023
@jordan-martins
Copy link

Hi,

This feature had a validation to assess the impact, right? If so, can the studies be shared? In any case, I would propose some official validation to be delivered by PdmV based on GEN-related people (please open a JIRA ticket in the PDMVRELVALS project).

Thanks,
Jordan
FYI @cms-sw/ppd-l2 @mseidel42 @cms-sw/generators-l2 @sihyunjeon @agrohsjean

@sihyunjeon
Copy link

@agrohsje

@mseidel42
Copy link
Contributor Author

Hi Jordan,

The impact on some ttbar observables was shown in the GEN meeting on Monday: https://indico.cern.ch/event/1293969/contributions/5438463/attachments/2668515/4624955/GEN%20Meeting%20190623%20v2.pdf#page=16

We think that this fix is the crucial change between Pythia 8.307 and 8.309 shown there.
By lucky coincidence, the impact is not large for our default alphaS value of 0.118.

However, we agreed to leave the defaults at the old (buggy) behavior and added new Pythia options to activate the bugfix for special samples requested by experts.
So I would not expect any change in the RelVals unless I managed to hide some more bugs in the code...

Best,
Markus

@sihyunjeon
Copy link

@mseidel42 i think @jordan-martins / ppd just wants to doubly make sure that pythia option switches you added functions as it is designed, just in case to avoid surprises. gen might comment more

@menglu21
Copy link

Hi @jordan-martins, I think @mseidel42 already explained well the motivation of this backport, and the validation using ttbar in https://indico.cern.ch/event/1293969/contributions/5438463/attachments/2668515/4624955/GEN%20Meeting%20190623%20v2.pdf#page=16 shows expected results from the fix. Since some UL requests i.e., bb4l may need this new feature (the correct results rather than the coincident-"correct" result) and I think it's worth to have it in the 10_6, or you want some more validation on other processes

@agrohsje
Copy link

we did such campaigns in the past via an extended relval. wouldn't;t that make sense to make sure we didn't miss anything. not that I don't trust markus. just to be 100% certain.

@Saptaparna
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2023

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9d279/33546/summary.html
COMMIT: 9506bf4
CMSSW: CMSSW_10_6_X_2023-07-02-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8555/33546/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@smuzaffar
Copy link
Contributor

@cms-sw/generators-l2 , we need cms-externals/pythia8#30 to be signed/megred first and then we can start testing this PR (as this PR will need changes e.g. correct commit of cms-externals/pythia8 after the merge of cms-externals/pythia8#30)

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

Pull request #8555 was updated.

@smuzaffar
Copy link
Contributor

hold

  • Hold this until decision comes from PPD to approve this backport.

@rappoccio , should we unhold this PR now?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9d279/34897/summary.html
COMMIT: bf6f949
CMSSW: CMSSW_10_6_X_2023-09-24-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8555/34897/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215350
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 144 log files, 103 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@rappoccio @antoniovilela , feel free to unhold and merge it for next 10.6.X Ibs/releases

@mseidel42
Copy link
Contributor Author

Just noticed that this is still open

@mseidel42
Copy link
Contributor Author

@rappoccio ?

@menglu21
Copy link

menglu21 commented Mar 8, 2024

@rappoccio , could we unhold this PR

@menglu21
Copy link

menglu21 commented Mar 12, 2024

@rappoccio a kind ping

@rappoccio
Copy link

unhold

@rappoccio
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link

merge

@cmsbuild cmsbuild merged commit 55def0a into cms-sw:IB/CMSSW_10_6_X/gcc700 Mar 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants