Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated root to tip of branch master #8734

Conversation

iarspider
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2023

A new Pull Request was created by @iarspider for branch IB/CMSSW_13_3_X/rootmaster.

@aandvalenzuela, @iarspider, @smuzaffar, @cmsbuild can you please review it and eventually sign? Thanks.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#42899 for CMSSW_13_3_ROOT6_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2023

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae6d52/35000/summary.html
COMMIT: 5dcece5
CMSSW: CMSSW_13_3_ROOT6_X_2023-10-01-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8734/35000/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae6d52/35000/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae6d52/35000/git-merge-result

Unit Tests

I found 6 errors in the following unit tests:

---> test CondToolsLHCInfoNewPopConTest had ERRORS
---> test BUFU_TEST had ERRORS
---> test TestIntegrationParameterSet had ERRORS
and more ...

RelVals

----- Begin Fatal Exception 02-Oct-2023 19:53:33 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing global end Run run: 1
   [1] Calling method for module DQMGenericClient/'primaryVertexResolutionClient'
   Additional Info:
      [a] Fatal Root Error: @SUB=Minuit2
VariableMetricBuilder Initial matrix not pos.def.

----- End Fatal Exception -------------------------------------------------

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#42899 for CMSSW_13_3_ROOT6_X

the unit test failures shouldn't be caused by this update (missing etc/gitinfo.txt - probably testing infrastructure hiccup); the relval one is odd.

@makortel
Copy link
Contributor

makortel commented Oct 2, 2023

The RelVal failure is a random failure tracked in cms-sw/cmssw#42029

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2023

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae6d52/35016/summary.html
COMMIT: 5dcece5
CMSSW: CMSSW_13_3_ROOT6_X_2023-10-01-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8734/35016/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae6d52/35016/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae6d52/35016/git-merge-result

Unit Tests

I found 5 errors in the following unit tests:

---> test TestIntegrationParameterSet had ERRORS
---> test unitTestsGroup_1_u2 had ERRORS
---> test unitTestsGroup_4_u20 had ERRORS
and more ...

RelVals

----- Begin Fatal Exception 03-Oct-2023 07:35:45 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing global end Run run: 1
   [1] Calling method for module DQMGenericClient/'primaryVertexResolutionClient'
   Additional Info:
      [a] Fatal Root Error: @SUB=Minuit2
VariableMetricBuilder Initial matrix not pos.def.

----- End Fatal Exception -------------------------------------------------

@iarspider
Copy link
Contributor Author

@smuzaffar should I retrigger the tests (now that SSO is fully functional)?

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#42899 for CMSSW_13_3_ROOT6_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2023

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae6d52/35035/summary.html
COMMIT: 5dcece5
CMSSW: CMSSW_13_3_ROOT6_X_2023-10-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8734/35035/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae6d52/35035/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae6d52/35035/git-merge-result

Unit Tests

I found 5 errors in the following unit tests:

---> test CondToolsLHCInfoNewPopConTest had ERRORS
---> test TestIntegrationParameterSet had ERRORS
---> test unitTestsGroup_1_u2 had ERRORS
and more ...

RelVals

----- Begin Fatal Exception 04-Oct-2023 18:41:13 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing global end Run run: 1
   [1] Calling method for module DQMGenericClient/'primaryVertexResolutionClient'
   Additional Info:
      [a] Fatal Root Error: @SUB=Minuit2
VariableMetricBuilder Initial matrix not pos.def.

----- End Fatal Exception -------------------------------------------------

@iarspider
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#42899 for CMSSW_13_3_ROOT6_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2023

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae6d52/35049/summary.html
COMMIT: 5dcece5
CMSSW: CMSSW_13_3_ROOT6_X_2023-10-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8734/35049/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae6d52/35049/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae6d52/35049/git-merge-result

Unit Tests

I found 5 errors in the following unit tests:

---> test CondToolsLHCInfoNewPopConTest had ERRORS
---> test TestIntegrationParameterSet had ERRORS
---> test unitTestsGroup_1_u2 had ERRORS
and more ...

RelVals

----- Begin Fatal Exception 05-Oct-2023 04:18:28 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing global end Run run: 1
   [1] Calling method for module DQMGenericClient/'primaryVertexResolutionClient'
   Additional Info:
      [a] Fatal Root Error: @SUB=Minuit2
VariableMetricBuilder Initial matrix not pos.def.

----- End Fatal Exception -------------------------------------------------

@smuzaffar
Copy link
Contributor

@makortel , the relval error does not look like a random here.

@smuzaffar
Copy link
Contributor

smuzaffar commented Oct 6, 2023

unit tests and relvals are failing due to root-project/root@5be58e5 change.

Error in <UnknownClass::ReadGitInfo()>: Cannot determine git info: etc/gitinfo.txt not found!

@smuzaffar
Copy link
Contributor

smuzaffar commented Oct 6, 2023

ah ok, most of unit tests are failing as now log contains the extra Error in <UnknownClass::ReadGitInfo()>: Cannot determine git info: etc/gitinfo.txt not found! message which is missing in the ref log file.
All the relvals though also contain this extra error message but not all of them are failing so not sure if 250202.181 relval failure has any thing to do with this root's error message

@smuzaffar
Copy link
Contributor

smuzaffar commented Oct 9, 2023

@iarspider , pls try latest root commit

@smuzaffar
Copy link
Contributor

closing in favor of #8743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants