[10.6..X] Add fix for segfault in Min Bias

[Dominic-Stafford]

Fixes a seg fault in Min Bias production due to some pointers in Herwig being incorrectly defined as static.

Backport of #8794 for Run 2 UL production.

[cmsbuild]

A new Pull Request was created by @Dominic-Stafford for branch IB/CMSSW_10_6_X/gcc700.

@iarspider, @aandvalenzuela, @smuzaffar, @cmsbuild can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

• Backported from Add fix for segfault in Min Bias #8794

[smuzaffar]

Backport of #8794

[smuzaffar]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ae4c5/35550/summary.html
COMMIT: 86d6eb5
CMSSW: CMSSW_10_6_X_2023-10-29-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8795/35550/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestGeneratorInterfacePythia8ConcurrentGeneratorFilter had ERRORS

Comparison Summary

Summary:

• You potentially removed 11 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215686
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215351
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 144 log files, 103 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[Dominic-Stafford]

I'm pretty sure the Pythia error is unrelated to this PR. There also appear to be some cvmfs errors when building, would it make sense to just restart the tests?

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ae4c5/35863/summary.html
COMMIT: 86d6eb5
CMSSW: CMSSW_10_6_X_2023-11-12-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8795/35863/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215686
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215351
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 144 log files, 103 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+externals

@cms-sw/orp-l2 please feel free to merge it for next 10.6.X release

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

@rappoccio @antoniovilela , feel free to merge this for 10.6.X

[antoniovilela]

+1