Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ROOT 6.14 to include forward-compatibility patch #8893

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

smuzaffar
Copy link
Contributor

Update ROOT 6.14 ref to include forward-compatibility patch for root files created by versions >=6.30.

Discussion here.

Initial issue here

FYI @nothingface0

@smuzaffar
Copy link
Contributor Author

@arooshap , I have set the commit status cmsbot/test — Ready for testing so hopefully comp bot will start the tests soon

@smuzaffar
Copy link
Contributor Author

@arooshap , this is the PR which DQM team needs.

@arooshap
Copy link

@smuzaffar thanks for the confirmation. Yes, the bot should start testing soon.

@arooshap
Copy link

+1 to f4981d0 on slc7_amd64_gcc630.
Build log can be found here.

@smuzaffar
Copy link
Contributor Author

@arooshap , this is ready to go in.
@nothingface0 , what it takes to get new dqmgui deployed?

@arooshap
Copy link

@smuzaffar we have to deploy this in CMSWEB. I will make a deployment today. Thank you for your help!

@arooshap arooshap merged commit 498aee8 into comp_gcc630 Dec 19, 2023
1 of 2 checks passed
@smuzaffar
Copy link
Contributor Author

thanks @arooshap , please ping me when this is deployed on cmsweb.

@arooshap
Copy link

@smuzaffar I just deployed it in vocms0731 (the pre-production VM).

@nothingface0
Copy link

nothingface0 commented Dec 19, 2023

@smuzaffar I just deployed it in vocms0731 (the pre-production VM).

@smuzaffar AFAIK, this is where the bin-by-bin comparison is made, could you trigger a PR test to check if it works?

Edit: From a simple test I did by opening a ROOT 6.30 file with the updated root, no errors appear. I expect the bin-by-bin comparison to run properly.

@smuzaffar
Copy link
Contributor Author

Thanks, there are couple if comparison job pending in jenkins. Hopefully those should be enough to test new dqm gui

@smuzaffar
Copy link
Contributor Author

@nothingface0 , please check PR cms-sw/cmssw#43596 results and its DQM bin-by-bin comparison. It looks good to me

@nothingface0
Copy link

@nothingface0 , please check PR cms-sw/cmssw#43596 results and its DQM bin-by-bin comparison. It looks good to me

Indeed, everything looks good and no errors in the logs from our side!

@smuzaffar smuzaffar deleted the root630-compatibility branch January 9, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants