Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10_6_X] Added cepgen 1.2.1patch1 to standard CMSSW tools #9042

Merged

Conversation

forthommel
Copy link
Contributor

@forthommel forthommel commented Feb 29, 2024

  • cloned from CLHEP spec-file
  • with interfacing libraries for HepMC2/3 (event output), LHAPDF (partonic photon PDF), and Pythia 6 ("legacy" proton remnant dissociation)
  • dropped HepMC3/Python/ROOT support for now (most likely not needed in 10_6_X workflows)
  • requires GSL, OpenBLAS, bzlib2

Backport of #8023, #8089, #8319, #8329, #9030, #9033
FYI: @bbilin

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @forthommel for branch IB/CMSSW_10_6_X/gcc700.

@aandvalenzuela, @smuzaffar, @iarspider, @cmsbuild can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 29, 2024

cms-bot internal usage

@forthommel forthommel changed the title Added cepgen to standard CMSSW tools [10_6_X] Added cepgen 1.2.1 to standard CMSSW tools Feb 29, 2024
@aandvalenzuela
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88804b/37817/summary.html
COMMIT: 17d9b7b
CMSSW: CMSSW_10_6_X_2024-02-25-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9042/37817/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@forthommel
Copy link
Contributor Author

Thanks again for triggering the test so quickly, @aandvalenzuela !
I see HepMC3 is problematic/not there in 10_6_X. Let me remove it and update the PR. Currently it is not being used downstream (will be eventually when the consumer code will switch to it).

@cmsbuild
Copy link
Contributor

Pull request #9042 was updated.

@aandvalenzuela
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88804b/37824/summary.html
COMMIT: dfb73e2
CMSSW: CMSSW_10_6_X_2024-02-25-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9042/37824/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:


CMake Error: CMAKE_Fortran_COMPILER not set, after EnableLanguage
-- Configuring incomplete, errors occurred!
See also "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/external/cepgen/1.2.1-c3650dc2293035c72706e1331e81b4d8/build/CMakeFiles/CMakeOutput.log".
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Oa4cjR (%build)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Oa4cjR (%build)



@cmsbuild
Copy link
Contributor

Pull request #9042 was updated.

@forthommel
Copy link
Contributor Author

In the build of CepGen a CMake configuration error was encountered:

The Ninja generator does not support Fortran using Ninja version

1.8.2

due to lack of required features.  Ninja 1.10 or higher is required.

The Ninja version was therefore bumped to 1.10.0 in 8f10f16.

@aandvalenzuela
Copy link
Contributor

please test

@forthommel
Copy link
Contributor Author

Many many thanks for your in-depth investigation, @smuzaffar!
I just force-pushed the 1.2.1patch1_gcc700 tag on cepgen/cepgen to address this well-spotted issue!

@forthommel
Copy link
Contributor Author

FYI @smuzaffar, it builds properly on my test bench!

@smuzaffar
Copy link
Contributor

test parameters:

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88804b/38118/summary.html
COMMIT: 0449e06
CMSSW: CMSSW_10_6_X_2024-03-10-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9042/38118/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Entering Package GeneratorInterface/CepGenInterface
Entering library rule at src/GeneratorInterface/CepGenInterface/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-03-10-0000/src/GeneratorInterface/CepGenInterface/plugins/CepGenGeneratorFilter.cc 
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-03-10-0000/src/GeneratorInterface/CepGenInterface/plugins/CepGenGeneratorFilter.cc:5:0:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-03-10-0000/src/GeneratorInterface/CepGenInterface/interface/CepGenGeneratorFilter.h: In constructor 'edm::GeneratorFilter::GeneratorFilter(const edm::ParameterSet&) [with HAD = gen::CepGenEventGenerator; DEC = gen::ExternalDecayDriver]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-03-10-0000/src/GeneratorInterface/CepGenInterface/interface/CepGenGeneratorFilter.h:16:5: error: 'init' was not declared in this scope
     init(iConfig);
     ^~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-03-10-0000/src/GeneratorInterface/CepGenInterface/interface/CepGenGeneratorFilter.h:16:5: note: suggested alternative: 'int'
     init(iConfig);
     ^~~~


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Local Products Rules ..... done
>> Creating project symlinks
>> Entering Package FWCore/Version
>> Entering Package GeneratorInterface/CepGenInterface
>> Compile sequence completed for CMSSW CMSSW_10_6_X_2024-03-10-0000
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --ignoreWarning=Wdeprecated-declarations --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-03-10-0000/tmp/slc7_amd64_gcc700/cache/log/src '||' 'true)'
++ scram build outputlog
Reading cached build data
Entering library rule at FWCore/Version
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-03-10-0000/src/FWCore/Version/src/GetFileFormatVersion.cc 


@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88804b/38127/summary.html
COMMIT: 0449e06
CMSSW: CMSSW_10_6_X_2024-03-10-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9042/38127/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 144 log files, 103 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@forthommel
Copy link
Contributor Author

Again, thanks a lot for your help on these 10_6_X developments, @smuzaffar!

@cmsbuild
Copy link
Contributor

REMINDER @rappoccio, @sextonkennedy, @antoniovilela: This PR was tested with cms-sw/cmssw#44268, please check if they should be merged together

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#44268

@antoniovilela
Copy link

+1

@cmsbuild cmsbuild merged commit 4496be0 into cms-sw:IB/CMSSW_10_6_X/gcc700 Mar 18, 2024
11 checks passed
@forthommel forthommel deleted the cepgen-10_6_X-gcc700 branch March 18, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants