Update CICADA external to v1.3.1 to prevent weight overwrite

[aloeliger]

This updates the CICADA external to v1.3.1

The major changes of this migration are the addition of x.1.2 models, designed to better use the output bit range, and more importantly, the addition of namespaces to the weights and types of all model versions, designed to prevent weight overwrite/symbol collision as seen in cms-sw/cmssw#44435 (the changes here can be seen in cms-hls4ml/CICADA#3).

This change is expected to change trigger results for 14_1 and forward, as it will dis-entangle CICADA from AXOL1TL.

@eyigitba, @slaurila, @quinnanm @thesps, FYI.

This PR is expected to be backported, as CICADA is expected to come online for datataking.

[cmsbuild]

A new Pull Request was created by @aloeliger for branch IB/CMSSW_14_1_X/master.

@aandvalenzuela, @iarspider, @smuzaffar, @cmsbuild can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad980f/38331/summary.html
COMMIT: eb674a2
CMSSW: CMSSW_14_1_X_2024-03-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9087/38331/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 102 lines from the logs
• Reco comparison results: 2734 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297369
• DQMHistoTests: Total failures: 3416
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3293933
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 10 / 46 workflows

[cmsbuild]

Pull request #9087 was updated.

[aloeliger]

Recent commit bumps this to version 1.3.1, which also includes a namespace protection on the model calling function. Changes can be seen in cms-hls4ml/CICADA#4 and https://github.com/cms-hls4ml/CICADA/releases/tag/v1.3.1

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad980f/38346/summary.html
COMMIT: 14a3906
CMSSW: CMSSW_14_1_X_2024-03-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9087/38346/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw Update tag for RecoEgamma-PhotonIdentification to V01-07-00 #9089

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad980f/38346/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad980f/38346/git-merge-result

Comparison Summary

Summary:

• You potentially removed 46 lines from the logs
• Reco comparison results: 53 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297369
• DQMHistoTests: Total failures: 110
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297239
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 10 / 46 workflows

[aloeliger]

The trigger results change is both expected and desired with regards to AXO.

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

assign l1

@cms-sw/l1-l2 , please review this update

[cmsbuild]

New categories assigned: l1

@epalencia,@aloeliger you have been requested to review this Pull request/Issue and eventually sign? Thanks

[aloeliger]

@smuzaffar I'm somewhat biased reviewing this, having made the PR. I guess @epalencia should sign this then?

[epalencia]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)