Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tensorflow-xla-runtime: fix for TF 2.15 #9107

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

smuzaffar
Copy link
Contributor

For Tf 2.15, the file runtime_fork_join.cc exists under xla/service/cpu/runtime_fork_join.cc as compare to 2.12 tensorflow/compiler/xla/service/cpu/runtime_fork_join.cc.

@smuzaffar
Copy link
Contributor Author

FYI @riga

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master.

@aandvalenzuela, @smuzaffar, @cmsbuild, @iarspider can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_1_TF_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

+externals

  • unit tests for production/master IB passed
  • cmssw-tool-conf ot TF_X IB also built successfully.

So merging it to fix the TF_X IBs failures

@smuzaffar smuzaffar merged commit c6e39a8 into IB/CMSSW_14_1_X/master Apr 2, 2024
7 of 10 checks passed
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-489585/38536/summary.html
COMMIT: 9332941
CMSSW: CMSSW_14_1_X_2024-04-01-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9107/38536/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 49 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297469
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3297440
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-489585/38534/summary.html
COMMIT: 9332941
CMSSW: CMSSW_14_1_TF_X_2024-03-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9107/38534/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-489585/38534/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-489585/38534/git-merge-result

Comparison Summary

Summary:

  • You potentially added 792 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6171 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297391
  • DQMHistoTests: Total failures: 31069
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3266300
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.24500000000000005 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.018 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 0.012 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 141.042 ): 0.012 KiB JetMET/SUSYDQM
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 2 / 46 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants