Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][BuildRules] Export cuda/rocm static libs from the base release #9117

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Apr 5, 2024

backport of #9115

This is bug fix for build rules.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_0_X/master.

@iarspider, @smuzaffar, @cmsbuild, @aandvalenzuela can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

test parameters:

  • addpkg = HeterogeneousTest/CUDAKernel

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar smuzaffar changed the title [14.0][BuildRules] Export cuda/rocm static libs fromt he base release [14.0][BuildRules] Export cuda/rocm static libs from the base release Apr 5, 2024
@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor Author

@cms-sw/orp-l2 , this fixes a bug in build rules for cuda/rocm linking ( see cms-sw/cmssw#44626 for detail). Without this a cmssw patch release will fail if a cuda package changed (e.g. HeterogeneousTest/CUDAKernel) in patch release and it has dependency on another cuda package (e.g. HeterogeneousTest/CUDADevice) which is not part of patch release.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9d98e/38625/summary.html
COMMIT: 1f48c90
CMSSW: CMSSW_14_0_X_2024-04-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9117/38625/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 123 lines to the logs
  • Reco comparison results: 51 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3346180
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3346155
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar merged commit 9e31d4e into IB/CMSSW_14_0_X/master Apr 6, 2024
10 checks passed
@smuzaffar smuzaffar deleted the smuzaffar-patch-4 branch April 22, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants