Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10_6_X] Bumped CepGen version to 1.2.3 #9123

Merged

Conversation

forthommel
Copy link
Contributor

This PR bumps the gcc7x version of CepGen to 1.2.3.
Changelog is available here.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

A new Pull Request was created by @forthommel for branch IB/CMSSW_10_6_X/gcc700.

@smuzaffar, @iarspider, @aandvalenzuela, @cmsbuild can you please review it and eventually sign? Thanks.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

cms-bot internal usage

@bbilin
Copy link

bbilin commented Apr 6, 2024

@cmsbuild please test

@forthommel forthommel changed the title Bumped CepGen version to 1.2.3 [10_6_X] Bumped CepGen version to 1.2.3 Apr 6, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f5a83/38650/summary.html
COMMIT: 48509aa
CMSSW: CMSSW_10_6_X_2024-04-05-2300/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9123/38650/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Patch (cepgen_nopython_noroot):
+ patch --no-backup-if-mismatch -p1 --fuzz=0
patching file CepGenAddOns/CMakeLists.txt
Hunk #1 FAILED at 14.
1 out of 1 hunk FAILED -- saving rejects to file CepGenAddOns/CMakeLists.txt.rej
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.7uPJaG (%prep)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.7uPJaG (%prep)



@forthommel
Copy link
Contributor Author

Oh right, I already forgot this patch! Updating it!

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

Pull request #9123 was updated.

@bbilin
Copy link

bbilin commented Apr 6, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f5a83/38654/summary.html
COMMIT: 7594828
CMSSW: CMSSW_10_6_X_2024-04-05-2300/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9123/38654/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Package GeneratorInterface/CepGenInterface built
>> Entering Package GeneratorInterface/CepGenInterface
Entering library rule at src/GeneratorInterface/CepGenInterface/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-04-05-2300/src/GeneratorInterface/CepGenInterface/plugins/CepGenGeneratorFilter.cc 
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-04-05-2300/src/GeneratorInterface/CepGenInterface/plugins/CepGenGeneratorFilter.cc:6:0:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-04-05-2300/src/GeneratorInterface/CepGenInterface/interface/CepGenEventGenerator.h:35:19: error: 'ParametersList' in namespace 'cepgen' does not name a type
     const cepgen::ParametersList proc_params_;
                   ^~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-04-05-2300/src/GeneratorInterface/CepGenInterface/interface/CepGenEventGenerator.h:36:48: error: 'ParametersList' is not a member of 'cepgen'
     std::vector > modif_modules_, output_modules_;
                                                ^~~~~~~~~~~~~~


@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @rappoccio, @antoniovilela: This PR was tested with cms-sw/cmssw#44648, please check if they should be merged together

@forthommel
Copy link
Contributor Author

They should :-)

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmssw#44648

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f5a83/38974/summary.html
COMMIT: 7594828
CMSSW: CMSSW_10_6_X_2024-04-14-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9123/38974/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215350
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 144 log files, 103 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@forthommel
Copy link
Contributor Author

Very good! Can we therefore assume the two backports (with #9124) are as fine as the master?

@antoniovilela
Copy link

@cms-sw/externals-l2
All good from your side?
Thanks.

@smuzaffar
Copy link
Contributor

+externals

All good from your side?

yes @cms-sw/orp-l2

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#44648

@rappoccio
Copy link

+1

@cmsbuild cmsbuild merged commit e5cc5fe into cms-sw:IB/CMSSW_10_6_X/gcc700 Apr 22, 2024
10 checks passed
@forthommel forthommel deleted the cepgen-10_6_X-gcc700 branch April 22, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants