-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10_6_X] Bumped CepGen version to 1.2.3 #9123
[10_6_X] Bumped CepGen version to 1.2.3 #9123
Conversation
A new Pull Request was created by @forthommel for branch IB/CMSSW_10_6_X/gcc700. @smuzaffar, @iarspider, @aandvalenzuela, @cmsbuild can you please review it and eventually sign? Thanks. |
cms-bot internal usage |
@cmsbuild please test |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f5a83/38650/summary.html External BuildI found compilation error when building: Patch (cepgen_nopython_noroot): + patch --no-backup-if-mismatch -p1 --fuzz=0 patching file CepGenAddOns/CMakeLists.txt Hunk #1 FAILED at 14. 1 out of 1 hunk FAILED -- saving rejects to file CepGenAddOns/CMakeLists.txt.rej error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.7uPJaG (%prep) RPM build errors: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.7uPJaG (%prep) |
Oh right, I already forgot this patch! Updating it! |
Pull request #9123 was updated. |
@cmsbuild please test |
-1 Failed Tests: Build BuildI found compilation error when building: >> Package GeneratorInterface/CepGenInterface built >> Entering Package GeneratorInterface/CepGenInterface Entering library rule at src/GeneratorInterface/CepGenInterface/plugins >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-04-05-2300/src/GeneratorInterface/CepGenInterface/plugins/CepGenGeneratorFilter.cc In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-04-05-2300/src/GeneratorInterface/CepGenInterface/plugins/CepGenGeneratorFilter.cc:6:0: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-04-05-2300/src/GeneratorInterface/CepGenInterface/interface/CepGenEventGenerator.h:35:19: error: 'ParametersList' in namespace 'cepgen' does not name a type const cepgen::ParametersList proc_params_; ^~~~~~~~~~~~~~ /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2024-04-05-2300/src/GeneratorInterface/CepGenInterface/interface/CepGenEventGenerator.h:36:48: error: 'ParametersList' is not a member of 'cepgen' std::vector > modif_modules_, output_modules_; ^~~~~~~~~~~~~~ |
REMINDER @sextonkennedy, @rappoccio, @antoniovilela: This PR was tested with cms-sw/cmssw#44648, please check if they should be merged together |
They should :-) |
please test with cms-sw/cmssw#44648 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f5a83/38974/summary.html Comparison SummarySummary:
|
Very good! Can we therefore assume the two backports (with #9124) are as fine as the master? |
@cms-sw/externals-l2 |
+externals
yes @cms-sw/orp-l2 |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR bumps the gcc7x version of CepGen to 1.2.3.
Changelog is available here.