Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmssw/external/lib to RIVET_ANALYSIS_PATH #9146

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master.

@cmsbuild, @aandvalenzuela, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

test parameters:

  • addpkg = GeneratorInterface/RivetInterface

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_1_MULTIARCHS_X

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffafe3/38913/summary.html
COMMIT: e980b1a
CMSSW: CMSSW_14_1_X_2024-04-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9146/38913/install.sh to create a dev area with all the needed externals and cmssw changes.

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffafe3/38914/summary.html
COMMIT: e980b1a
CMSSW: CMSSW_14_1_MULTIARCHS_X_2024-04-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9146/38914/install.sh to create a dev area with all the needed externals and cmssw changes.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #9146 was updated.

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_1_MULTIARCHS_X

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit 04efa93 into IB/CMSSW_14_1_X/master Apr 18, 2024
14 of 16 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffafe3/38925/summary.html
COMMIT: 3e5b49d
CMSSW: CMSSW_14_1_X_2024-04-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9146/38925/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 21 lines to the logs
  • Reco comparison results: 58 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3319599
  • DQMHistoTests: Total failures: 15
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3319564
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffafe3/38922/summary.html
COMMIT: 3e5b49d
CMSSW: CMSSW_14_1_MULTIARCHS_X_2024-04-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9146/38922/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
24834.78 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 186 lines from the logs
  • Reco comparison results: 70609 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3319599
  • DQMHistoTests: Total failures: 304408
  • DQMHistoTests: Total nulls: 268
  • DQMHistoTests: Total successes: 3014903
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -2.0850000000000004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.586 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): -2.906 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 140.043,... ): -0.016 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.063 ): -0.070 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): 0.086 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): 0.016 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): -0.836 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.469 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 1.774 KiB SiStrip/MechanicalView
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 18 / 46 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants