Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop crab nosort option; fizes for zsh #9282

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

smuzaffar
Copy link
Contributor

This PR fixes the following issues

  • Update cms-common so that cmsset_default.sh do not fail under zsh ( export -f fails for zsh)
  • Drop nosort option from crab auto complete script. This allow it to run it under el7. nosort option was added for bash>=4.4 which in el7 we have bash 4.2
  • Fix the logic for zsh

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2024

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cms-bot#2281

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cms-bot#2281

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cms-bot#2281

@smuzaffar smuzaffar merged commit 1fb7532 into IB/CMSSW_14_1_X/master Jul 5, 2024
9 of 11 checks passed
@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2024

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cms-bot#2281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants