Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace old HF shower data in SimG4CMS/Calo. #980

Merged
1 commit merged into from Sep 7, 2014
Merged

Replace old HF shower data in SimG4CMS/Calo. #980

1 commit merged into from Sep 7, 2014

Conversation

ghost
Copy link

@ghost ghost commented Sep 2, 2014

According to issue #795.

@ghost ghost mentioned this pull request Sep 2, 2014
Closed
@civanch
Copy link
Contributor

civanch commented Sep 2, 2014

-1
@Degano , please do not remove SimG4CMS/Calo/data/HFShowerLibrary_npmt_eta4_16en.root, because it is our main SL for 2015.

@aledegano
Replace old HF shower data.
a573e3c 
According to issue #795.
@ghost
Copy link
Author

ghost commented Sep 2, 2014

@civanch fixed.

@civanch
Copy link
Contributor

civanch commented Sep 3, 2014

@Degano, sorry after today discussion with HCAL experts its turn out that not the best file was taken for 2015 production.

The correct one is located in /afs/cern.ch/user/a/abdullin/public/HF_NewShowerLibrary_NewPMTs/HFShowerLibrary_npmt_noatt_eta4_16en.root - it is also required change file name inside data-SimG4CMS-Calo.spec

@civanch
Copy link
Contributor

civanch commented Sep 5, 2014

At the last SIM meeting (September,5) it was confirmed that we need to have two HF SLs:
HFShowerLibrary_npmt_noatt_eta4_16en.root
HFShowerLibrary_oldpmt_noatt_eta4_16en.root
@Degano, please, proceed with this PR

ghost pushed a commit that referenced this pull request Sep 7, 2014
@aledegano
Merge pull request #980 from degano/simg4cms_calo_72X
9c16715 
Replace old HF shower data in SimG4CMS/Calo.
@ghost ghost merged commit 9c16715 into cms-sw:IB/CMSSW_7_2_X/stable Sep 7, 2014
@ghost ghost deleted the simg4cms_calo_72X branch September 7, 2014 07:05
@civanch
Copy link
Contributor

civanch commented Sep 7, 2014

@Degano, sorry but the most important part is not there: for 2015 run HFShowerLibrary_npmt_noatt_eta4_16en.root is needed instead of existing file HFShowerLibrary_npmt_eta4_16en.root

We need this urgently for pre6.

@ghost
Copy link
Author

ghost commented Sep 8, 2014

@civanch I am taking care of it right now.

@ghost ghost mentioned this pull request Sep 8, 2014
Merged
@ghost
Copy link
Author

ghost commented Sep 8, 2014

@civanch sorry for the mess, fixed in #990

@ghost ghost mentioned this pull request Sep 9, 2014
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@civanch @aledegano