subtract ped mean from DIGIs when re-calibrating on-the-fly

subtract pedestal mean and update the kev2mip conversion
cms-sw · Jun 27, 2019 · 1d49340 · 1d49340
1 parent e47cb14
commit 1d49340
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/SimCalorimetry/HGCalSimProducers/python/hgcalDigitizer_cfi.py b/SimCalorimetry/HGCalSimProducers/python/hgcalDigitizer_cfi.py
@@ -178,7 +178,7 @@
         scaleByArea   = cms.bool(True),
         noise         = cms.PSet(refToPSet_ = cms.string("HGCAL_noise_heback")), #scales both for scint raddam and sipm dark current
         calibDigis    = cms.bool(True),
-        keV2MIP       = cms.double(1./500.0),
+        keV2MIP       = cms.double(1./675.0),
         doTimeSamples = cms.bool(False),
         nPEperMIP = cms.double(21.0),
         nTotalPE  = cms.double(7500),

diff --git a/SimCalorimetry/HGCalSimProducers/src/HGCHEbackDigitizer.cc b/SimCalorimetry/HGCalSimProducers/src/HGCHEbackDigitizer.cc
@@ -264,7 +264,7 @@ void HGCHEbackDigitizer::runRealisticDigitizer(std::unique_ptr<HGCalDigiCollecti
       //const float nPixelTot = nPixel + sqrt(nPixel) * CLHEP::RandGaussQ::shoot(engine, 0., 0.05); //FDG: just a note for now, par to be defined
 
       //scale to calibrated response depending on the calibDigis_ flag
-      float totalMIPs = calibDigis_ ? (float)npe / scaledPePerMip : nPixel / nPEperMIP_;
+      float totalMIPs = calibDigis_ ? std::max((npe - meanN), 0.f) / scaledPePerMip : nPixel / nPEperMIP_;
 
       if (debug && totalIniMIPs > 0) {
         LogDebug("HGCHEbackDigitizer") << "npeS: " << npeS << " npeN: " << npeN << " npe: " << npe