Skip to content

Commit

Permalink
Removed unnecessary std::move from Geometry/ForwardGeometry
Browse files Browse the repository at this point in the history
clang gave a warning stating the use of std::move on a returned
value prevents a compiler optimization.
  • Loading branch information
Dr15Jones committed Sep 4, 2018
1 parent dbbbce7 commit 20f4063
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Geometry/ForwardGeometry/src/CastorHardcodeGeometryLoader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ CastorHardcodeGeometryLoader::load( DetId::Detector /*det*/,
fill( HcalCastorDetId::EM, hg.get() ) ;
fill( HcalCastorDetId::HAD, hg.get() ) ;
}
return std::move(hg);
return hg;
}

std::unique_ptr<CaloSubdetectorGeometry>
Expand All @@ -53,7 +53,7 @@ CastorHardcodeGeometryLoader::load()
( new CastorGeometry( extTopology ) ) ;
fill( HcalCastorDetId::EM, hg.get() ) ;
fill( HcalCastorDetId::HAD, hg.get() ) ;
return std::move(hg);
return hg;
}

void
Expand Down

0 comments on commit 20f4063

Please sign in to comment.