Skip to content

Commit

Permalink
Cleanup that helps static analyzer
Browse files Browse the repository at this point in the history
Remove unused members of DetIdAssociator. Removing
these eliminates some of the spurious problems reported
by the static analyzer used to look for threading
issues.
  • Loading branch information
wddgit committed Apr 2, 2014
1 parent c43c550 commit 3531f02
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
4 changes: 0 additions & 4 deletions TrackingTools/TrackAssociator/interface/DetIdAssociator.h
Expand Up @@ -101,8 +101,6 @@ class DetIdAssociator{
virtual int iEta (const GlobalPoint&) const;
/// look-up map phi index
virtual int iPhi (const GlobalPoint&) const;
/// set a specific track propagator to be used
virtual void setPropagator(Propagator* ptr){ ivProp_ = ptr; };
/// number of bins of the look-up map in phi dimension
int nPhiBins() const { return nPhi_;}
/// number of bins of the look-up map in eta dimension
Expand Down Expand Up @@ -160,8 +158,6 @@ class DetIdAssociator{
double maxEta_;
double minTheta_;

Propagator *ivProp_;

// Detector fiducial volume
// approximated as a closed cylinder with non-zero width.
// Parameters are extracted from the active detector elements.
Expand Down
2 changes: 1 addition & 1 deletion TrackingTools/TrackAssociator/src/DetIdAssociator.cc
Expand Up @@ -25,7 +25,7 @@
DetIdAssociator::DetIdAssociator(const int nPhi, const int nEta, const double etaBinSize)
:nPhi_(nPhi),nEta_(nEta),
lookupMap_(nPhi_*nEta_,std::pair<unsigned int, unsigned int>(0,0)),
theMapIsValid_(false),etaBinSize_(etaBinSize),ivProp_(0)
theMapIsValid_(false),etaBinSize_(etaBinSize)
{
if (nEta_ <= 0 || nPhi_ <= 0) throw cms::Exception("FatalError") << "incorrect look-up map size. Cannot initialize such a map.";
maxEta_ = etaBinSize_*nEta_/2;
Expand Down

0 comments on commit 3531f02

Please sign in to comment.