avoid unnecessary unique_ptr

cms-sw · Dec 20, 2018 · 3d8d8ba · 3d8d8ba
1 parent cf75e2f
commit 3d8d8ba
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 14 deletions.
diff --git a/RecoLocalFastTime/FTLClusterizer/interface/MTDCPEBase.h b/RecoLocalFastTime/FTLClusterizer/interface/MTDCPEBase.h
@@ -65,13 +65,13 @@ class MTDCPEBase : public MTDClusterParameterEstimator
    {
 
       DetParam const & dp = detParam(det);
-      std::unique_ptr<ClusterParam> cp = createClusterParam(cl);
-      setTheClu( dp, *cp );
+      ClusterParam cp(cl);
+      setTheClu( dp, cp );
       auto tuple = std::make_tuple(
-				   localPosition(dp, *cp),
-				   localError(dp, *cp),
-				   clusterTime(dp, *cp),
-				   clusterTimeError(dp, *cp)
+				   localPosition(dp, cp),
+				   localError(dp, cp),
+				   clusterTime(dp, cp),
+				   clusterTimeError(dp, cp)
 				   );
       return tuple;
    }
@@ -89,8 +89,6 @@ class MTDCPEBase : public MTDClusterParameterEstimator
 
 
 private:
-   virtual std::unique_ptr<ClusterParam> createClusterParam(const FTLCluster & cl) const;
-
    //--------------------------------------------------------------------------
    // This is where the action happens.
    //--------------------------------------------------------------------------

diff --git a/RecoLocalFastTime/FTLClusterizer/src/MTDCPEBase.cc b/RecoLocalFastTime/FTLClusterizer/src/MTDCPEBase.cc
@@ -77,12 +77,6 @@ MTDCPEBase::setTheClu( DetParam const & dp, ClusterParam & cp ) const
 {   
 }
 
-std::unique_ptr<MTDCPEBase::ClusterParam> MTDCPEBase::createClusterParam(const FTLCluster & cl) const
-{
-  return std::make_unique<ClusterParam>(cl);
-}
-
-
 //------------------------------------------------------------------------
 MTDCPEBase::DetParam const & MTDCPEBase::detParam(const GeomDetUnit & det) const 
 {