Skip to content

Commit

Permalink
Take care of Kevin's comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Sunanda committed Dec 23, 2020
1 parent bf1a96d commit 3dd5257
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions Geometry/HGCalCommonData/src/HGCalWaferIndex.cc
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,18 @@ int32_t HGCalWaferIndex::waferIndex(int32_t layer, int32_t waferU, int32_t wafer
return id;
}

int HGCalWaferIndex::waferLayer(const int32_t id) { return (id >> HGCalProperty::kHGCalLayerOffset) & HGCalProperty::kHGCalLayerMask; }
int32_t HGCalWaferIndex::waferLayer(const int32_t id) { return (id >> HGCalProperty::kHGCalLayerOffset) & HGCalProperty::kHGCalLayerMask; }

int HGCalWaferIndex::waferU(const int32_t id) {
int32_t HGCalWaferIndex::waferU(const int32_t id) {
int32_t iu = (id >> HGCalProperty::kHGCalWaferUOffset) & HGCalProperty::kHGCalWaferUMask;
return (((id >> HGCalProperty::kHGCalWaferUSignOffset) & HGCalProperty::kHGCalWaferUSignMask) ? -iu : iu);
}

int HGCalWaferIndex::waferV(const int32_t id) {
int32_t HGCalWaferIndex::waferV(const int32_t id) {
int32_t iv = (id >> HGCalProperty::kHGCalWaferVOffset) & HGCalProperty::kHGCalWaferVMask;
return (((id >> HGCalProperty::kHGCalWaferVSignOffset) & HGCalProperty::kHGCalWaferVSignMask) ? -iv : iv);
}

int HGCalWaferIndex::waferCopy(const int32_t id) { return (id >> HGCalProperty::kHGCalWaferCopyOffset) & HGCalProperty::kHGCalWaferCopyMask; }
int32_t HGCalWaferIndex::waferCopy(const int32_t id) { return (id >> HGCalProperty::kHGCalWaferCopyOffset) & HGCalProperty::kHGCalWaferCopyMask; }

bool HGCalWaferIndex::waferFormat(const int32_t id) { return ((id & HGCalProperty::kHGCalLayerOldMask) == 0); }

0 comments on commit 3dd5257

Please sign in to comment.