Skip to content

Commit

Permalink
Merge pull request #21986 from gartung/TrackingTools-RecoGeometry-ret…
Browse files Browse the repository at this point in the history
…urntype

TrackingTools/RecoGeometry: change return type of ESProducers
  • Loading branch information
cmsbuild committed Jan 29, 2018
2 parents 31d9d2e + b212d4a commit 44a08f1
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,11 @@ DetLayerGeometryESProducer::DetLayerGeometryESProducer(const edm::ParameterSet &

DetLayerGeometryESProducer::~DetLayerGeometryESProducer() {}

std::shared_ptr<DetLayerGeometry>
std::unique_ptr<DetLayerGeometry>
DetLayerGeometryESProducer::produce(const RecoGeometryRecord & iRecord){


geometry_ = std::make_shared<DetLayerGeometry>();
return geometry_;
return std::make_unique<DetLayerGeometry>();
}


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ class DetLayerGeometryESProducer: public edm::ESProducer{
public:
DetLayerGeometryESProducer(const edm::ParameterSet & p);
~DetLayerGeometryESProducer() override;
std::shared_ptr<DetLayerGeometry> produce(const RecoGeometryRecord &);
private:
std::shared_ptr<DetLayerGeometry> geometry_;
std::unique_ptr<DetLayerGeometry> produce(const RecoGeometryRecord &);
};


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ GlobalDetLayerGeometryESProducer::GlobalDetLayerGeometryESProducer(const edm::Pa

GlobalDetLayerGeometryESProducer::~GlobalDetLayerGeometryESProducer() {}

std::shared_ptr<DetLayerGeometry>
std::unique_ptr<DetLayerGeometry>
GlobalDetLayerGeometryESProducer::produce(const RecoGeometryRecord & iRecord){

edm::ESHandle<GeometricSearchTracker> tracker;
Expand All @@ -27,8 +27,7 @@ GlobalDetLayerGeometryESProducer::produce(const RecoGeometryRecord & iRecord){
iRecord.getRecord<TrackerRecoGeometryRecord>().get(tracker);
iRecord.getRecord<MuonRecoGeometryRecord>().get(muon);

geometry_ = std::make_shared<GlobalDetLayerGeometry>(tracker.product(), muon.product());
return geometry_;
return std::make_unique<GlobalDetLayerGeometry>(tracker.product(), muon.product());
}


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ class GlobalDetLayerGeometryESProducer: public edm::ESProducer{
public:
GlobalDetLayerGeometryESProducer(const edm::ParameterSet & p);
~GlobalDetLayerGeometryESProducer() override;
std::shared_ptr<DetLayerGeometry> produce(const RecoGeometryRecord &);
private:
std::shared_ptr<DetLayerGeometry> geometry_;
std::unique_ptr<DetLayerGeometry> produce(const RecoGeometryRecord &);
};


Expand Down

0 comments on commit 44a08f1

Please sign in to comment.