clang check HiggsAnalysis

cms-sw · Oct 7, 2017 · 51d91b0 · 51d91b0
1 parent 5349f79
commit 51d91b0
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 16 deletions.
diff --git a/HiggsAnalysis/HiggsToGammaGamma/src/PhotonFixCMS.cc b/HiggsAnalysis/HiggsToGammaGamma/src/PhotonFixCMS.cc
@@ -50,7 +50,7 @@ bool PhotonFixCMS::initialise(const edm::EventSetup &iSetup, const std::string &
 	EBDetId eb(id,ip+1);
 
 	const CaloCellGeometry *cellGeometry = barrelGeometry->getGeometry(eb);
-	GlobalPoint crystalPos = cellGeometry->getPosition();
+	const GlobalPoint& crystalPos = cellGeometry->getPosition();
 	bc[85*iz+ie][ip][0]=crystalPos.eta();
 	bc[85*iz+ie][ip][1]=crystalPos.phi();
       }
@@ -103,7 +103,7 @@ if(iz==0) PhotonFix::endcapCrystal(ix,iy,valid[ix][iy]);
     val_count+=1;
 
 	  const CaloCellGeometry *cellGeometry = endcapGeometry->getGeometry(ee);
-	  GlobalPoint crystalPos = cellGeometry->getPosition();
+	  const GlobalPoint& crystalPos = cellGeometry->getPosition();
 	  ec[iz][ix][iy][0]=asinh(crystalPos.x()/fabs(crystalPos.z()));
 	  ec[iz][ix][iy][1]=asinh(crystalPos.y()/fabs(crystalPos.z()));
 	}

diff --git a/HiggsAnalysis/Skimming/interface/HeavyChHiggsToTauNuSkim.h b/HiggsAnalysis/Skimming/interface/HeavyChHiggsToTauNuSkim.h
@@ -27,15 +27,15 @@
 #include "DataFormats/BTauReco/interface/IsolatedTauTagInfo.h"
 #include "DataFormats/JetReco/interface/CaloJetCollection.h"
 
-#include <math.h>
+#include <cmath>
 
 class HeavyChHiggsToTauNuSkim : public edm::EDFilter {
 
     public:
         explicit HeavyChHiggsToTauNuSkim(const edm::ParameterSet&);
-        ~HeavyChHiggsToTauNuSkim();
+        ~HeavyChHiggsToTauNuSkim() override;
 
-  	virtual bool filter(edm::Event&, const edm::EventSetup& );
+  	bool filter(edm::Event&, const edm::EventSetup& ) override;
 
    private:
 	double deltaPhi(double phi1, double phi2){

diff --git a/HiggsAnalysis/Skimming/interface/HiggsTo2GammaSkim.h b/HiggsAnalysis/Skimming/interface/HiggsTo2GammaSkim.h
@@ -31,10 +31,10 @@ class HiggsTo2GammaSkim : public edm::EDFilter {
   explicit HiggsTo2GammaSkim(const edm::ParameterSet&);
 
   // Destructor
-  ~HiggsTo2GammaSkim();
+  ~HiggsTo2GammaSkim() override;
 
   /// Get event properties to send to builder to fill seed collection
-  virtual bool filter(edm::Event&, const edm::EventSetup& );
+  bool filter(edm::Event&, const edm::EventSetup& ) override;
 
 
  private:

diff --git a/HiggsAnalysis/Skimming/interface/HiggsToWW2LeptonsSkim.h b/HiggsAnalysis/Skimming/interface/HiggsToWW2LeptonsSkim.h
@@ -29,10 +29,10 @@
 class HiggsToWW2LeptonsSkim : public edm::EDFilter {
     public:
        explicit HiggsToWW2LeptonsSkim(const edm::ParameterSet&);
-       ~HiggsToWW2LeptonsSkim();
-       virtual void endJob() ;
+       ~HiggsToWW2LeptonsSkim() override;
+       void endJob() override ;
 
-       virtual bool filter(edm::Event&, const edm::EventSetup&);
+       bool filter(edm::Event&, const edm::EventSetup&) override;
 
    private:
       double singleTrackPtMin_;

diff --git a/HiggsAnalysis/Skimming/interface/HiggsToZZ4LeptonsPreFilter.h b/HiggsAnalysis/Skimming/interface/HiggsToZZ4LeptonsPreFilter.h
@@ -32,10 +32,10 @@ class HiggsToZZ4LeptonsPreFilter : public edm::EDFilter {
   explicit HiggsToZZ4LeptonsPreFilter(const edm::ParameterSet&);
 
   // Destructor
-  ~HiggsToZZ4LeptonsPreFilter();
+  ~HiggsToZZ4LeptonsPreFilter() override;
 
   /// Get event properties to send to builder to fill seed collection
-  virtual bool filter(edm::Event&, const edm::EventSetup& );
+  bool filter(edm::Event&, const edm::EventSetup& ) override;
 
 
  private:

diff --git a/HiggsAnalysis/Skimming/interface/HiggsToZZ4LeptonsSkim.h b/HiggsAnalysis/Skimming/interface/HiggsToZZ4LeptonsSkim.h
@@ -35,10 +35,10 @@ class HiggsToZZ4LeptonsSkim : public edm::EDFilter {
   explicit HiggsToZZ4LeptonsSkim(const edm::ParameterSet&);
 
   // Destructor
-  ~HiggsToZZ4LeptonsSkim();
+  ~HiggsToZZ4LeptonsSkim() override;
 
   /// Get event properties to send to builder to fill seed collection
-  virtual bool filter(edm::Event&, const edm::EventSetup& );
+  bool filter(edm::Event&, const edm::EventSetup& ) override;
 
 
  private:

diff --git a/HiggsAnalysis/Skimming/interface/HiggsToZZ4LeptonsSkimEff.h b/HiggsAnalysis/Skimming/interface/HiggsToZZ4LeptonsSkimEff.h
@@ -33,10 +33,10 @@ class HiggsToZZ4LeptonsSkimEff : public edm::EDAnalyzer {
   explicit HiggsToZZ4LeptonsSkimEff(const edm::ParameterSet&);
 
   // Destructor
-  ~HiggsToZZ4LeptonsSkimEff();
+  ~HiggsToZZ4LeptonsSkimEff() override;
 
   /// Get event properties to send to builder to fill seed collection
-  virtual void analyze(const edm::Event&, const edm::EventSetup& );
+  void analyze(const edm::Event&, const edm::EventSetup& ) override;
 
 
  private: