Skip to content

Commit

Permalink
add LogWarning
Browse files Browse the repository at this point in the history
  • Loading branch information
@mtosi
mtosi committed Sep 3, 2018
1 parent 3410be5 commit 552f4a4
Show file tree
Hide file tree
Showing 6 changed files with 173 additions and 38 deletions.
49 changes: 41 additions & 8 deletions DQMOffline/Trigger/plugins/BPHMonitor.cc
View file
Expand Up @@ -11,10 +11,14 @@

BPHMonitor::BPHMonitor( const edm::ParameterSet& iConfig ) :
folderName_ ( iConfig.getParameter<std::string>("FolderName") )
, muoToken_ ( mayConsume<reco::MuonCollection> (iConfig.getParameter<edm::InputTag>("muons") ) )
, bsToken_ ( mayConsume<reco::BeamSpot> (iConfig.getParameter<edm::InputTag>("beamSpot")))
, trToken_ ( mayConsume<reco::TrackCollection> (iConfig.getParameter<edm::InputTag>("tracks")))
, phToken_ ( mayConsume<reco::PhotonCollection> (iConfig.getParameter<edm::InputTag>("photons")))
, muoInputTag_ ( iConfig.getParameter<edm::InputTag>("muons") )
, bsInputTag_ ( iConfig.getParameter<edm::InputTag>("beamSpot") )
, trInputTag_ ( iConfig.getParameter<edm::InputTag>("tracks") )
, phInputTag_ ( iConfig.getParameter<edm::InputTag>("photons") )
, muoToken_ ( mayConsume<reco::MuonCollection> ( muoInputTag_ ) )
, bsToken_ ( mayConsume<reco::BeamSpot> ( bsInputTag_ ) )
, trToken_ ( mayConsume<reco::TrackCollection> ( trInputTag_ ) )
, phToken_ ( mayConsume<reco::PhotonCollection> ( phInputTag_ ) )
, phi_binning_ ( getHistoPSet (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet> ("phiPSet") ) )
, pt_binning_ ( getHistoPSet (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet> ("ptPSet") ) )
, eta_binning_ ( getHistoPSet (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet> ("etaPSet") ) )
Expand Down Expand Up @@ -57,7 +61,7 @@ BPHMonitor::BPHMonitor( const edm::ParameterSet& iConfig ) :
, mincos ( iConfig.getParameter<double>("mincos" ) )
, minDS ( iConfig.getParameter<double>("minDS" ) )
, hltTrigResTag_ (mayConsume<edm::TriggerResults>( iConfig.getParameter<edm::ParameterSet>("denGenericTriggerEventPSet").getParameter<edm::InputTag>("hltInputTag")))
, hltInputTag_ (mayConsume<trigger::TriggerEvent>( iConfig.getParameter<edm::InputTag>("hltTriggerSummaryAOD")))
, hltInputTag_ (mayConsume<trigger::TriggerEvent>( iConfig.getParameter<edm::InputTag>("hltTriggerSummaryAOD"))) /* mia : you should make it configurable !!!" */
, hltpaths_num ( iConfig.getParameter<edm::ParameterSet>("numGenericTriggerEventPSet").getParameter<std::vector<std::string>>("hltPaths"))
, hltpaths_den ( iConfig.getParameter<edm::ParameterSet>("denGenericTriggerEventPSet").getParameter<std::vector<std::string>>("hltPaths"))
, trSelection_ ( iConfig.getParameter<std::string>("muoSelection") )
Expand Down Expand Up @@ -125,6 +129,12 @@ BPHMonitor::BPHMonitor( const edm::ParameterSet& iConfig ) :
DiMudR_.denominator = nullptr;


// this vector has to be alligned to the the number of Tokens accessed by this module
warningPrinted4token_.push_back(false); // MuonCollection
warningPrinted4token_.push_back(false); // BeamSpot
warningPrinted4token_.push_back(false); // TrackCollection
warningPrinted4token_.push_back(false); // PhotonCollection

}

BPHMonitor::~BPHMonitor()
Expand Down Expand Up @@ -345,15 +355,33 @@ void BPHMonitor::analyze(edm::Event const& iEvent, edm::EventSetup const& iSetup

edm::Handle<reco::BeamSpot> beamSpot;
iEvent.getByToken( bsToken_, beamSpot);
if ( !beamSpot.isValid() ) return;
if ( !beamSpot.isValid() ) {
if (warningPrinted4token_[0]) {
edm::LogWarning("BPHMonitor") << "skipping events because the collection " << bsInputTag_.label().c_str() << " is not available";
warningPrinted4token_[0] = true;
}
return;
}

edm::Handle<reco::MuonCollection> muoHandle;
iEvent.getByToken( muoToken_, muoHandle );
if ( !muoHandle.isValid() ) return;
if ( !muoHandle.isValid() ) {
if (warningPrinted4token_[1]) {
edm::LogWarning("BPHMonitor") << "skipping events because the collection " << muoInputTag_.label().c_str() << " is not available";
warningPrinted4token_[1] = true;
}
return;
}

edm::Handle<reco::TrackCollection> trHandle;
iEvent.getByToken( trToken_, trHandle );
if ( !trHandle.isValid() ) return;
if ( !trHandle.isValid() ) {
if (warningPrinted4token_[2]) {
edm::LogWarning("BPHMonitor") << "skipping events because the collection " << trInputTag_.label().c_str() << " is not available";
warningPrinted4token_[2] = true;
}
return;
}

edm::Handle<reco::PhotonCollection> phHandle;
iEvent.getByToken( phToken_, phHandle );
Expand Down Expand Up @@ -692,6 +720,11 @@ void BPHMonitor::analyze(edm::Event const& iEvent, edm::EventSetup const& iSetup
phEta_.denominator->Fill(p.eta());
phPt_.denominator ->Fill(p.pt());
}
} else {
if (warningPrinted4token_[3]) {
edm::LogWarning("BPHMonitor") << "skipping events because the collection " << phInputTag_.label().c_str() << " is not available";
warningPrinted4token_[3] = true;
}
}

}
Expand Down
7 changes: 7 additions & 0 deletions DQMOffline/Trigger/plugins/BPHMonitor.h
View file
Expand Up @@ -102,6 +102,11 @@ class BPHMonitor : public DQMEDAnalyzer
std::string folderName_;
std::string histoSuffix_;

edm::InputTag muoInputTag_;
edm::InputTag bsInputTag_;
edm::InputTag trInputTag_;
edm::InputTag phInputTag_;

edm::EDGetTokenT<reco::MuonCollection> muoToken_;
edm::EDGetTokenT<reco::BeamSpot> bsToken_;
edm::EDGetTokenT<reco::TrackCollection> trToken_;
Expand Down Expand Up @@ -197,6 +202,8 @@ class BPHMonitor : public DQMEDAnalyzer
StringCutObjectSelector<reco::Track,true> trSelection_;
StringCutObjectSelector<reco::Track,true> trSelection_ref;
StringCutObjectSelector<reco::Candidate::LorentzVector,true> DMSelection_ref;

std::vector<bool> warningPrinted4token_;
};

#endif // METMONITOR_H
73 changes: 58 additions & 15 deletions DQMOffline/Trigger/plugins/HTMonitor.cc
View file
@@ -1,3 +1,4 @@
#include "FWCore/MessageLogger/interface/MessageLogger.h"
#include "DQMOffline/Trigger/plugins/HTMonitor.h"

#include "CommonTools/TriggerUtils/interface/GenericTriggerEventFlag.h"
Expand All @@ -10,11 +11,16 @@

HTMonitor::HTMonitor( const edm::ParameterSet& iConfig ) :
folderName_ ( iConfig.getParameter<std::string>("FolderName") )
, metToken_ ( consumes<reco::PFMETCollection> (iConfig.getParameter<edm::InputTag>("met") ) )
, jetToken_ ( mayConsume<reco::JetView> (iConfig.getParameter<edm::InputTag>("jets") ) )
, eleToken_ ( mayConsume<reco::GsfElectronCollection>(iConfig.getParameter<edm::InputTag>("electrons") ) )
, muoToken_ ( mayConsume<reco::MuonCollection> (iConfig.getParameter<edm::InputTag>("muons") ) )
, vtxToken_ ( mayConsume<reco::VertexCollection> (iConfig.getParameter<edm::InputTag>("vertices") ) )
, metInputTag_ ( iConfig.getParameter<edm::InputTag> ("met") )
, jetInputTag_ ( iConfig.getParameter<edm::InputTag> ("jets") )
, eleInputTag_ ( iConfig.getParameter<edm::InputTag> ("electrons") )
, muoInputTag_ ( iConfig.getParameter<edm::InputTag> ("muons") )
, vtxInputTag_ ( iConfig.getParameter<edm::InputTag> ("vertices") )
, metToken_ ( consumes<reco::PFMETCollection> ( metInputTag_ ) )
, jetToken_ ( mayConsume<reco::JetView> ( jetInputTag_ ) )
, eleToken_ ( mayConsume<reco::GsfElectronCollection>( eleInputTag_ ) )
, muoToken_ ( mayConsume<reco::MuonCollection> ( muoInputTag_ ) )
, vtxToken_ ( mayConsume<reco::VertexCollection> ( vtxInputTag_ ) )
, ht_variable_binning_ ( iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<std::vector<double> >("htBinning") )
, ht_binning_ ( getHistoPSet (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet> ("htPSet") ) )
, ls_binning_ ( getHistoPSet (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet> ("lsPSet") ) )
Expand All @@ -30,6 +36,7 @@ HTMonitor::HTMonitor( const edm::ParameterSet& iConfig ) :
, nmuons_ ( iConfig.getParameter<unsigned>("nmuons" ) )
, dEtaCut_ ( iConfig.getParameter<double>("dEtaCut") )
{
/* mia: THIS CODE SHOULD BE DELETED !!!! */
string quantity = iConfig.getParameter<std::string>("quantity");
if(quantity == "HT")
{
Expand All @@ -47,6 +54,13 @@ HTMonitor::HTMonitor( const edm::ParameterSet& iConfig ) :
{
throw cms::Exception("quantity not defined") << "the quantity '" << quantity << "' is undefined. Please check your config!" << std::endl;
}

// this vector has to be alligned to the the number of Tokens accessed by this module
warningPrinted4token_.push_back(false); // PFMETCollection
warningPrinted4token_.push_back(false); // JetCollection
warningPrinted4token_.push_back(false); // GsfElectronCollection
warningPrinted4token_.push_back(false); // MuonCollection
warningPrinted4token_.push_back(false); // VertexCollection
}

HTMonitor::~HTMonitor() = default;
Expand Down Expand Up @@ -180,13 +194,25 @@ void HTMonitor::analyze(edm::Event const& iEvent, edm::EventSetup const& iSetup)

edm::Handle<reco::PFMETCollection> metHandle;
iEvent.getByToken( metToken_, metHandle );
if ( !metHandle.isValid() ) return;
if ( !metHandle.isValid() ) {
if (warningPrinted4token_[0]) {
edm::LogWarning("HTMonitor") << "skipping events because the collection " << metInputTag_.label().c_str() << " is not available";
warningPrinted4token_[0] = true;
}
return;
}
reco::PFMET pfmet = metHandle->front();
if ( ! metSelection_( pfmet ) ) return;

edm::Handle<reco::JetView> jetHandle; //add a configurable jet collection & jet pt selection
iEvent.getByToken( jetToken_, jetHandle );
if ( !jetHandle.isValid() ) return;
if ( !jetHandle.isValid() ) {
if (warningPrinted4token_[1]) {
edm::LogWarning("HTMonitor") << "skipping events because the collection " << jetInputTag_.label().c_str() << " is not available";
warningPrinted4token_[1] = true;
}
return;
}
std::vector<reco::Jet> jets;
if ( jetHandle->size() < njets_ ) return;
for ( auto const & j : *jetHandle ) {
Expand All @@ -212,18 +238,30 @@ void HTMonitor::analyze(edm::Event const& iEvent, edm::EventSetup const& iSetup)
if ( eleSelection_( e ) ) electrons.push_back(e);
}
if ( electrons.size() < nelectrons_ ) return;
} else {
if (warningPrinted4token_[2]) {
edm::LogWarning("HTMonitor") << "skipping events because the collection " << jetInputTag_.label().c_str() << " is not available";
warningPrinted4token_[2] = true;
}
}


reco::Vertex vtx;
edm::Handle<reco::VertexCollection> vtxHandle;
iEvent.getByToken(vtxToken_, vtxHandle);

reco::Vertex vtx;
for (auto const & v : *vtxHandle) {
bool isFake = v.isFake() ;

if (!isFake) {
vtx = v;
break;
if ( vtxHandle.isValid() ) {
for (auto const & v : *vtxHandle) {
bool isFake = v.isFake() ;

if (!isFake) {
vtx = v;
break;
}
}
} else {
if (warningPrinted4token_[3]) {
edm::LogWarning("HTMonitor") << "skipping events because the collection " << vtxInputTag_.label().c_str() << " is not available";
warningPrinted4token_[3] = true;
}
}

Expand All @@ -236,6 +274,11 @@ void HTMonitor::analyze(edm::Event const& iEvent, edm::EventSetup const& iSetup)
if ( muoSelection_( m ) && m.isGlobalMuon() && m.isPFMuon() && m.globalTrack()->normalizedChi2() < 10. && m.globalTrack()->hitPattern().numberOfValidMuonHits() > 0 && m.numberOfMatchedStations() > 1 && fabs(m.muonBestTrack()->dxy(vtx.position())) < 0.2 && fabs(m.muonBestTrack()->dz(vtx.position())) < 0.5 && m.innerTrack()->hitPattern().numberOfValidPixelHits() > 0 && m.innerTrack()->hitPattern().trackerLayersWithMeasurement() > 5 ) muons.push_back(m);
}
if ( muons.size() < nmuons_ ) return;
} else {
if (warningPrinted4token_[4]) {
edm::LogWarning("HTMonitor") << "skipping events because the collection " << muoInputTag_.label().c_str() << " is not available";
warningPrinted4token_[4] = true;
}
}

// fill histograms
Expand Down
10 changes: 8 additions & 2 deletions DQMOffline/Trigger/plugins/HTMonitor.h
View file
Expand Up @@ -90,6 +90,12 @@ class HTMonitor : public DQMEDAnalyzer
std::string histoSuffix_;
quant quantity_;

edm::InputTag metInputTag_;
edm::InputTag jetInputTag_;
edm::InputTag eleInputTag_;
edm::InputTag muoInputTag_;
edm::InputTag vtxInputTag_;

edm::EDGetTokenT<reco::PFMETCollection> metToken_;
edm::EDGetTokenT< reco::JetView > jetToken_;
edm::EDGetTokenT<reco::GsfElectronCollection> eleToken_;
Expand Down Expand Up @@ -124,8 +130,8 @@ class HTMonitor : public DQMEDAnalyzer
Nbin_PHI, -MAXedge_PHI, MAXedge_PHI
};


std::vector<bool> warningPrinted4token_;

};

#endif // HTMONITOR_H
#endif // HTMONITOR_H
65 changes: 52 additions & 13 deletions DQMOffline/Trigger/plugins/METMonitor.cc
View file
Expand Up @@ -14,11 +14,16 @@

METMonitor::METMonitor( const edm::ParameterSet& iConfig ) :
folderName_ ( iConfig.getParameter<std::string>("FolderName") )
, metToken_ ( consumes<reco::PFMETCollection> (iConfig.getParameter<edm::InputTag>("met") ) )
, jetToken_ ( mayConsume<reco::PFJetCollection> (iConfig.getParameter<edm::InputTag>("jets") ) )
, eleToken_ ( mayConsume<reco::GsfElectronCollection>(iConfig.getParameter<edm::InputTag>("electrons") ) )
, muoToken_ ( mayConsume<reco::MuonCollection> (iConfig.getParameter<edm::InputTag>("muons") ) )
, vtxToken_ ( mayConsume<reco::VertexCollection> (iConfig.getParameter<edm::InputTag>("vertices") ) )
, metInputTag_ ( iConfig.getParameter<edm::InputTag> ("met") )
, jetInputTag_ ( iConfig.getParameter<edm::InputTag> ("jets") )
, eleInputTag_ ( iConfig.getParameter<edm::InputTag> ("electrons") )
, muoInputTag_ ( iConfig.getParameter<edm::InputTag> ("muons") )
, vtxInputTag_ ( iConfig.getParameter<edm::InputTag> ("vertices") )
, metToken_ ( consumes<reco::PFMETCollection> ( metInputTag_ ) )
, jetToken_ ( mayConsume<reco::PFJetCollection> ( jetInputTag_ ) )
, eleToken_ ( mayConsume<reco::GsfElectronCollection>( eleInputTag_ ) )
, muoToken_ ( mayConsume<reco::MuonCollection> ( muoInputTag_ ) )
, vtxToken_ ( mayConsume<reco::VertexCollection> ( vtxInputTag_ ) )
, met_variable_binning_ ( iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<std::vector<double> >("metBinning") )
, met_binning_ ( getHistoPSet (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet> ("metPSet") ) )
, ls_binning_ ( getHistoPSet (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet> ("lsPSet") ) )
Expand All @@ -32,6 +37,12 @@ METMonitor::METMonitor( const edm::ParameterSet& iConfig ) :
, nelectrons_ ( iConfig.getParameter<unsigned>("nelectrons" ) )
, nmuons_ ( iConfig.getParameter<unsigned>("nmuons" ) )
{
// this vector has to be alligned to the the number of Tokens accessed by this module
warningPrinted4token_.push_back(false); // PFMETCollection
warningPrinted4token_.push_back(false); // JetCollection
warningPrinted4token_.push_back(false); // GsfElectronCollection
warningPrinted4token_.push_back(false); // MuonCollection
warningPrinted4token_.push_back(false); // VertexCollection
}

METMonitor::~METMonitor() = default;
Expand Down Expand Up @@ -148,7 +159,13 @@ void METMonitor::analyze(edm::Event const& iEvent, edm::EventSetup const& iSetup
if (den_genTriggerEventFlag_->on() && ! den_genTriggerEventFlag_->accept( iEvent, iSetup) ) return;
edm::Handle<reco::PFMETCollection> metHandle;
iEvent.getByToken( metToken_, metHandle );
if ( !metHandle.isValid() ) return;
if ( !metHandle.isValid() ) {
if (warningPrinted4token_[0]) {
edm::LogWarning("METMonitor") << "skipping events because the collection " << metInputTag_.label().c_str() << " is not available";
warningPrinted4token_[0] = true;
}
return;
}
reco::PFMET pfmet = metHandle->front();
if ( ! metSelection_( pfmet ) ) return;

Expand All @@ -165,6 +182,11 @@ void METMonitor::analyze(edm::Event const& iEvent, edm::EventSetup const& iSetup
jets.push_back(j);
}
}
} else {
if (warningPrinted4token_[1]) {
edm::LogWarning("METMonitor") << "skipping events because the collection " << jetInputTag_.label().c_str() << " is not available";
warningPrinted4token_[1] = true;
}
}
float deltaPhi_met_j1= 10.0;
float deltaPhi_j1_j2 = 10.0;
Expand All @@ -181,21 +203,33 @@ void METMonitor::analyze(edm::Event const& iEvent, edm::EventSetup const& iSetup
if ( eleSelection_( e ) ) electrons.push_back(e);
}
if (electrons.size() < nelectrons_ ) return;
} else {
if (warningPrinted4token_[2]) {
edm::LogWarning("METMonitor") << "skipping events because the collection " << jetInputTag_.label().c_str() << " is not available";
warningPrinted4token_[2] = true;
}
}

reco::Vertex vtx;
edm::Handle<reco::VertexCollection> vtxHandle;
iEvent.getByToken(vtxToken_, vtxHandle);

reco::Vertex vtx;
for (auto const & v : *vtxHandle) {
bool isFake = v.isFake() ;
if ( vtxHandle.isValid() ) {
for (auto const & v : *vtxHandle) {
bool isFake = v.isFake() ;

if (!isFake) {
vtx = v;
break;
if (!isFake) {
vtx = v;
break;
}
}
} else {
if (warningPrinted4token_[3]) {
edm::LogWarning("METMonitor") << "skipping events because the collection " << vtxInputTag_.label().c_str() << " is not available";
warningPrinted4token_[3] = true;
}
}


std::vector<reco::Muon> muons;
edm::Handle<reco::MuonCollection> muoHandle;
iEvent.getByToken( muoToken_, muoHandle );
Expand All @@ -206,6 +240,11 @@ void METMonitor::analyze(edm::Event const& iEvent, edm::EventSetup const& iSetup
if ( muoSelection_( m ) && pass ) muons.push_back(m);
}
if ( muons.size() < nmuons_ ) return;
} else {
if (warningPrinted4token_[4]) {
edm::LogWarning("METMonitor") << "skipping events because the collection " << muoInputTag_.label().c_str() << " is not available";
warningPrinted4token_[4] = true;
}
}

// filling histograms (denominator)
Expand Down
7 changes: 7 additions & 0 deletions DQMOffline/Trigger/plugins/METMonitor.h
View file
Expand Up @@ -88,6 +88,12 @@ class METMonitor : public DQMEDAnalyzer
std::string folderName_;
std::string histoSuffix_;

edm::InputTag metInputTag_;
edm::InputTag jetInputTag_;
edm::InputTag eleInputTag_;
edm::InputTag muoInputTag_;
edm::InputTag vtxInputTag_;

edm::EDGetTokenT<reco::PFMETCollection> metToken_;
edm::EDGetTokenT<reco::PFJetCollection> jetToken_;
edm::EDGetTokenT<reco::GsfElectronCollection> eleToken_;
Expand Down Expand Up @@ -123,6 +129,7 @@ class METMonitor : public DQMEDAnalyzer
N_PHI, -MAX_PHI, MAX_PHI
};

std::vector<bool> warningPrinted4token_;

};

Expand Down

0 comments on commit 552f4a4

Please sign in to comment.