Skip to content

Commit

Permalink
Add missing parentheses
Browse files Browse the repository at this point in the history
Logical not is applied to int type, which is clearly a mistake. Add the
missing parentheses to apply it for the comparison.

    Validation/MuonGEMRecHits/src/GEMRecHitsValidation.cc:127:39:
    warning: logical not is only applied to the left hand side of comparison
    [-Wlogical-not-parentheses]
    Validation/MuonGEMRecHits/src/GEMRecHitsValidation.cc:127:39:
    warning: comparison of constant '13' with boolean expression is always
    false [-Wbool-compare]

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
  • Loading branch information
David Abdurachmanov authored and David Abdurachmanov committed Jan 6, 2016
1 parent 1864445 commit 7419d89
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Validation/MuonGEMRecHits/src/GEMRecHitsValidation.cc
Expand Up @@ -124,7 +124,7 @@ void GEMRecHitsValidation::analyze(const edm::Event& e,
continue;
}

if (!(abs(hits-> particleType())) == 13) continue;
if (!(abs(hits-> particleType()) == 13)) continue;

//const LocalPoint p0(0., 0., 0.);
//const GlobalPoint Gp0(GEMGeometry_->idToDet(hits->detUnitId())->surface().toGlobal(p0));
Expand Down

0 comments on commit 7419d89

Please sign in to comment.