Skip to content

Commit

Permalink
add vertex monitoring @HLT to online DQM as well
Browse files Browse the repository at this point in the history
fix

bug fix

add ndof

add PV monitoring@HLT for online DQM

Conflicts:
	DQMOffline/RecoB/plugins/PrimaryVertexMonitor.cc
	DQMOffline/RecoB/plugins/PrimaryVertexMonitor.h

Ignore vertex collections for which the track refs are null

Print LogWarning once per stream in case of missing input collection

Ignore vertex collections for which the track refs are null (as done by @makortel in 336f8af)

Print LogWarning once per stream in case of missing input collection (as done by @makortel in 0b5aad4)

fix PVV@HLT

fix

Conflicts:
	DQMOffline/RecoB/plugins/PrimaryVertexMonitor.h

add standardValidationNoHLT

fix VALIDATION step in workflows w/ HLT:@Fake

fix

fix

fix DQM step as well !

Conflicts:
	Configuration/PyReleaseValidation/python/relval_steps.py

add main PAGs sequence for offline DQM

fix

add PAGs client

fix

fix handling of condDataValidation

fix HARVESTING step in run1

no HLT Validation HARVESTING and no HLT DQM HARVESTING

Conflicts:
	Configuration/PyReleaseValidation/python/relval_steps.py

re-fix

fix

fix
  • Loading branch information
mtosi committed Apr 4, 2017
1 parent 74fd4cc commit 992c499
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 1 deletion.
2 changes: 1 addition & 1 deletion DQMOffline/RecoB/plugins/PrimaryVertexMonitor.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class PrimaryVertexMonitor : public DQMEDAnalyzer {
std::string AlignmentLabel_;
int ndof_;
bool errorPrinted_;

// the histos
MonitorElement *nbvtx, *nbgvtx, *nbtksinvtx[2], *trksWeight[2], *score[2];
MonitorElement *tt[2];
Expand Down
20 changes: 20 additions & 0 deletions Validation/RecoVertex/src/PrimaryVertexAnalyzer4PUSlimmed.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1387,6 +1387,26 @@ void PrimaryVertexAnalyzer4PUSlimmed::analyze(const edm::Event& iEvent,
continue;
}

{
// check upfront that refs to track are (likely) to be valid
bool ok = true;
for(const auto& v: *recVtxs) {
if(v.tracksSize() > 0) {
const auto& ref = v.trackRefAt(0);
if(ref.isNull() || !ref.isAvailable()) {
if(!errorPrintedForColl_[iToken]) {
edm::LogWarning("PrimaryVertexAnalyzer4PUSlimmed")
<< "Skipping vertex collection: " << label << " since likely the track collection the vertex has refs pointing to is missing (at least the first TrackBaseRef is null or not available)";
errorPrintedForColl_[iToken] = true;
}
ok = false;
}
}
}
if(!ok)
continue;
}

reco::VertexRecoToSimCollection vertex_r2s = vertexAssociator.associateRecoToSim(recVtxs, TVCollectionH);
reco::VertexSimToRecoCollection vertex_s2r = vertexAssociator.associateSimToReco(recVtxs, TVCollectionH);

Expand Down

0 comments on commit 992c499

Please sign in to comment.