address C.West's comments

cms-sw · Feb 13, 2020 · a52fafd · a52fafd
1 parent a292992
commit a52fafd
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 4 deletions.
diff --git a/CalibCalorimetry/HcalTPGAlgos/src/LutXml.cc b/CalibCalorimetry/HcalTPGAlgos/src/LutXml.cc
@@ -318,7 +318,8 @@ HcalSubdetector LutXml::subdet_from_crate(int crate_, int slot, int fiber) {
     else
       return HcalEndcap;
   }
-  return HcalOther;
+  edm::LogWarning("LutXml::subdet_from_crate") << "crate " << crate_ << " is not accounted for";
+  return HcalEmpty;
 }
 
 int LutXml::a_to_i(char *inbuf) {

diff --git a/CaloOnlineTools/HcalOnlineDb/test/cardPhysicsSkeleton.sh b/CaloOnlineTools/HcalOnlineDb/test/cardPhysicsSkeleton.sh
@@ -0,0 +1,25 @@
+Tag="<LUTTAG>"
+Run=1
+GlobalTag="<Globaltag>"
+description="<Description of updates>"
+HOAsciiInput=HO_ped9_inputLUTcoderDec.txt
+
+ElectronicsMap=""
+LutMetadata=""
+LUTCorrs=""
+QIETypes=""
+QIEData=""
+SiPMParameters=""
+TPParameters=""
+TPChannelParameters=""
+
+ChannelQuality=""
+Gains="<TestTagNameOfChangingCondition>"
+Pedestals=""
+RespCorrs=""
+L1TriggerObjects="<TestTagNameOfChangingCondition>"
+
+OldTag="<OldTagToCompareTo>"
+OldRun=1
+
+applyO2O=true
diff --git a/CaloOnlineTools/HcalOnlineDb/test/template.py b/CaloOnlineTools/HcalOnlineDb/test/template.py
@@ -1,8 +1,7 @@
 import FWCore.ParameterSet.Config as cms
-from Configuration.StandardSequences.Eras import eras
 
-from Configuration.Eras.Era_Run2_2018_cff import Run2_2018
-process = cms.Process("TEST", Run2_2018)
+from Configuration.Eras.Era_Run3_cff import Run3
+process = cms.Process("TEST", Run3)
 
 process.load("FWCore.MessageLogger.MessageLogger_cfi")
 process.MessageLogger.categories.append('LUT')