Merge pull request #10004 from hroskes/geometry-comparison-runnumber-75X

Backport of #10003 - Various All In One Tool bugfixes
cms-sw · Jul 15, 2015 · ab390fd · ab390fd
2 parents 2642b83 + 43db440
commit ab390fd
Show file tree

Hide file tree

Showing 13 changed files with 103 additions and 153 deletions.
diff --git a/Alignment/OfflineValidation/macros/trackSplitPlot.C b/Alignment/OfflineValidation/macros/trackSplitPlot.C
@@ -223,6 +223,10 @@ TCanvas *trackSplitPlot(Int_t nFiles,TString *files,TString *names,TString xvar,
                 x = xint;
             if (xvar == "runNumber")
                 runNumber = x;
+            if (yvar == "phi" && y >= pi)
+                y -= 2*pi;
+            if (yvar == "phi" && y <= -pi)
+                y += 2*pi;
             if ((runNumber < minrun && runNumber > 1) || (runNumber > maxrun && maxrun > 0))  //minrun and maxrun are global variables.
             {
                 notincluded++;
@@ -1913,6 +1917,10 @@ Double_t findStatistic(Statistic what,Int_t nFiles,TString *files,TString var,Ch
                 x = xint;
             if (var == "runNumber")
                 runNumber = x;
+            if (var == "phi" && x >= pi)
+                x -= 2*pi;
+            if (var == "phi" && x <= -pi)
+                x += 2*pi;
             if ((runNumber < minrun && runNumber > 1) || (runNumber > maxrun && maxrun > 0)) continue;
 
             totallength++;

diff --git a/Alignment/OfflineValidation/python/TkAlAllInOneTool/alignment.py b/Alignment/OfflineValidation/python/TkAlAllInOneTool/alignment.py
@@ -6,12 +6,23 @@
 class Alignment:
     def __init__(self, name, config, runGeomComp = "1"):
         self.condShorts = {
-            "TrackerAlignmentErrorExtendedRcd":
-                {"zeroAPE":{"connectString": ("frontier://FrontierProd"
-                                              "/CMS_CONDITIONS"),
-                            "tagName": "TrackerAlignmentExtendedErr_2009_v2_express_IOVs",
-
-                            "labelName": ""}}}
+            "TrackerAlignmentErrorExtendedRcd": {
+                "zeroAPE": {
+                    "connectString":("frontier://FrontierProd"
+                                             "/CMS_CONDITIONS"),
+                    "tagName": "TrackerIdealGeometryErrorsExtended210_mc",
+                    "labelName": ""
+                }
+            },
+            "TrackerSurfaceDeformationRcd": {
+                "zeroDeformations": {
+                    "connectString":("frontier://FrontierProd"
+                                             "/CMS_CONDITIONS"),
+                    "tagName": "TrackerSurfaceDeformations_zero",
+                    "labelName": ""
+                }
+            },
+        }
         section = "alignment:%s"%name
         if not config.has_section( section ):
             raise AllInOneError, ("section %s not found. Please define the "
@@ -24,6 +35,9 @@ def __init__(self, name, config, runGeomComp = "1"):
             self.title = config.get(section,"title")
         else:
             self.title = self.name
+        if (int(runGeomComp) != 1):
+            self.name += "_run" + runGeomComp
+            self.title += " run " + runGeomComp
         if "|" in self.title or "," in self.title or '"' in self.title:
             msg = "The characters '|', '\"', and ',' cannot be used in the alignment title!"
             raise AllInOneError(msg)

diff --git a/Alignment/OfflineValidation/python/TkAlAllInOneTool/alternateValidationTemplates.py b/Alignment/OfflineValidation/python/TkAlAllInOneTool/alternateValidationTemplates.py
@@ -77,15 +77,7 @@
 process.TrackerTrackHitFilter.useTrajectories= True  # this is needed only if you require some selections; but it will work even if you don't ask for them
 process.TrackerTrackHitFilter.minimumHits = 8
 process.TrackerTrackHitFilter.commands = cms.vstring("keep PXB","keep PXE","keep TIB","keep TID","keep TOB","keep TEC")
-process.TrackerTrackHitFilter.detsToIgnore = [
-     # see https://hypernews.cern.ch/HyperNews/CMS/get/tracker-performance/484.html
-    # TIB / TID
-    #369136710, 369136714, 402668822,
-    # TOB
-    #436310989, 436310990, 436299301, 436299302,
-    # TEC
-    #470340521, 470063045, 470063046, 470114669, 470114670, 470161093, 470161094, 470164333, 470164334, 470312005, 470312006, 470312009, 470067405, 470067406, 470128813
-]
+process.TrackerTrackHitFilter.detsToIgnore = []
 process.TrackerTrackHitFilter.replaceWithInactiveHits = True
 process.TrackerTrackHitFilter.stripAllInvalidHits = False
 process.TrackerTrackHitFilter.rejectBadStoNHits = True
@@ -157,7 +149,7 @@
  ##
  ## Magnetic Field
  ##
-process.load("Configuration/StandardSequences/MagneticField_.oO[magneticField]Oo._cff")
+process.load("Configuration/StandardSequences/.oO[magneticField]Oo._cff")
 
 .oO[condLoad]Oo.
 
@@ -303,7 +295,7 @@
 ##
 ## Magnetic Field
 ##
-process.load("Configuration/StandardSequences/MagneticField_.oO[magneticField]Oo._cff")
+process.load("Configuration/StandardSequences/.oO[magneticField]Oo._cff")
 
 .oO[LorentzAngleTemplate]Oo.
   
@@ -460,7 +452,7 @@
  ##
  ## Magnetic Field
  ##
-process.load("Configuration.StandardSequences.MagneticField_.oO[magneticField]Oo._cff")
+process.load("Configuration.StandardSequences..oO[magneticField]Oo._cff")
 
 .oO[condLoad]Oo.
 
@@ -518,15 +510,7 @@
 process.TrackerTrackHitFilter.useTrajectories= True  # this is needed only if you require some selections; but it will work even if you don't ask for them
 process.TrackerTrackHitFilter.minimumHits = 8
 process.TrackerTrackHitFilter.commands = cms.vstring("keep PXB","keep PXE","keep TIB","keep TID","keep TOB","keep TEC")
-process.TrackerTrackHitFilter.detsToIgnore = [
-     # see https://hypernews.cern.ch/HyperNews/CMS/get/tracker-performance/484.html
-    # TIB / TID
-    #369136710, 369136714, 402668822,
-    # TOB
-    #436310989, 436310990, 436299301, 436299302,
-    # TEC
-    #470340521, 470063045, 470063046, 470114669, 470114670, 470161093, 470161094, 470164333, 470164334, 470312005, 470312006, 470312009, 470067405, 470067406, 470128813
-]
+process.TrackerTrackHitFilter.detsToIgnore = []
 process.TrackerTrackHitFilter.replaceWithInactiveHits = True
 process.TrackerTrackHitFilter.stripAllInvalidHits = False
 process.TrackerTrackHitFilter.rejectBadStoNHits = True
@@ -588,15 +572,7 @@
 process.TrackerTrackHitFilter.useTrajectories= True  # this is needed only if you require some selections; but it will work even if you don't ask for them
 process.TrackerTrackHitFilter.minimumHits = 8
 process.TrackerTrackHitFilter.commands = cms.vstring("keep PXB","keep PXE","keep TIB","keep TID","keep TOB","keep TEC")
-process.TrackerTrackHitFilter.detsToIgnore = [
-     # see https://hypernews.cern.ch/HyperNews/CMS/get/tracker-performance/484.html
-    # TIB / TID
-    #369136710, 369136714, 402668822,
-    # TOB
-    #436310989, 436310990, 436299301, 436299302,
-    # TEC
-    #470340521, 470063045, 470063046, 470114669, 470114670, 470161093, 470161094, 470164333, 470164334, 470312005, 470312006, 470312009, 470067405, 470067406, 470128813
-]
+process.TrackerTrackHitFilter.detsToIgnore = []
 process.TrackerTrackHitFilter.replaceWithInactiveHits = True
 process.TrackerTrackHitFilter.stripAllInvalidHits = False
 process.TrackerTrackHitFilter.rejectBadStoNHits = True
@@ -659,15 +635,7 @@
 process.TrackerTrackHitFilter.useTrajectories= True  # this is needed only if you require some selections; but it will work even if you don't ask for them
 process.TrackerTrackHitFilter.minimumHits = 8
 process.TrackerTrackHitFilter.commands = cms.vstring("keep PXB","keep PXE","keep TIB","keep TID","keep TOB","keep TEC")
-process.TrackerTrackHitFilter.detsToIgnore = [
-     # see https://hypernews.cern.ch/HyperNews/CMS/get/tracker-performance/484.html
-    # TIB / TID
-    #369136710, 369136714, 402668822,
-    # TOB
-    #436310989, 436310990, 436299301, 436299302,
-    # TEC
-    #470340521, 470063045, 470063046, 470114669, 470114670, 470161093, 470161094, 470164333, 470164334, 470312005, 470312006, 470312009, 470067405, 470067406, 470128813
-]
+process.TrackerTrackHitFilter.detsToIgnore = []
 process.TrackerTrackHitFilter.replaceWithInactiveHits = True
 process.TrackerTrackHitFilter.stripAllInvalidHits = False
 process.TrackerTrackHitFilter.rejectBadStoNHits = True
@@ -730,15 +698,7 @@
 process.TrackerTrackHitFilter.useTrajectories= True  # this is needed only if you require some selections; but it will work even if you don't ask for them
 process.TrackerTrackHitFilter.minimumHits = 8
 process.TrackerTrackHitFilter.commands = cms.vstring("keep PXB","keep PXE","keep TIB","keep TID","keep TOB","keep TEC")
-process.TrackerTrackHitFilter.detsToIgnore = [
-     # see https://hypernews.cern.ch/HyperNews/CMS/get/tracker-performance/484.html
-    # TIB / TID
-    #369136710, 369136714, 402668822,
-    # TOB
-    #436310989, 436310990, 436299301, 436299302,
-    # TEC
-    #470340521, 470063045, 470063046, 470114669, 470114670, 470161093, 470161094, 470164333, 470164334, 470312005, 470312006, 470312009, 470067405, 470067406, 470128813
-]
+process.TrackerTrackHitFilter.detsToIgnore = []
 process.TrackerTrackHitFilter.replaceWithInactiveHits = True
 process.TrackerTrackHitFilter.stripAllInvalidHits = False
 process.TrackerTrackHitFilter.rejectBadStoNHits = True
@@ -801,15 +761,7 @@
 process.TrackerTrackHitFilter.useTrajectories= True  # this is needed only if you require some selections; but it will work even if you don't ask for them
 process.TrackerTrackHitFilter.minimumHits = 8
 process.TrackerTrackHitFilter.commands = cms.vstring("keep PXB","keep PXE","keep TIB","keep TID","keep TOB","keep TEC")
-process.TrackerTrackHitFilter.detsToIgnore = [
-     # see https://hypernews.cern.ch/HyperNews/CMS/get/tracker-performance/484.html
-    # TIB / TID
-    #369136710, 369136714, 402668822,
-    # TOB
-    #436310989, 436310990, 436299301, 436299302,
-    # TEC
-    #470340521, 470063045, 470063046, 470114669, 470114670, 470161093, 470161094, 470164333, 470164334, 470312005, 470312006, 470312009, 470067405, 470067406, 470128813
-]
+process.TrackerTrackHitFilter.detsToIgnore = []
 process.TrackerTrackHitFilter.replaceWithInactiveHits = True
 process.TrackerTrackHitFilter.stripAllInvalidHits = False
 process.TrackerTrackHitFilter.rejectBadStoNHits = True
@@ -854,16 +806,7 @@
 process.TrackerTrackHitFilter.useTrajectories= True  # this is needed only if you require some selections; but it will work even if you don't ask for them
 process.TrackerTrackHitFilter.minimumHits = 8
 process.TrackerTrackHitFilter.commands = cms.vstring("keep PXB","keep PXE","keep TIB","keep TID","keep TOB","keep TEC")
-process.TrackerTrackHitFilter.detsToIgnore = [
-     # see https://hypernews.cern.ch/HyperNews/CMS/get/tracker-performance/484.html
-    # TIB / TID
-    #369136710, 369136714, 402668822,
-    # TOB
-    #436310989, 436310990, 436299301, 436299302,
-
-    # TEC
-    #470340521, 470063045, 470063046, 470114669, 470114670, 470161093, 470161094, 470164333, 470164334, 470312005, 470312006, 470312009, 470067405, 470067406, 470128813
-]
+process.TrackerTrackHitFilter.detsToIgnore = []
 process.TrackerTrackHitFilter.replaceWithInactiveHits = True
 process.TrackerTrackHitFilter.stripAllInvalidHits = False
 process.TrackerTrackHitFilter.rejectBadStoNHits = True
@@ -917,15 +860,7 @@
 process.TrackerTrackHitFilter.useTrajectories= True  # this is needed only if you require some selections; but it will work even if you don't ask for them
 process.TrackerTrackHitFilter.minimumHits = 8
 process.TrackerTrackHitFilter.commands = cms.vstring("keep PXB","keep PXE","keep TIB","keep TID","keep TOB","keep TEC")
-process.TrackerTrackHitFilter.detsToIgnore = [
-     # see https://hypernews.cern.ch/HyperNews/CMS/get/tracker-performance/484.html
-    # TIB / TID
-    #369136710, 369136714, 402668822,
-    # TOB
-    #436310989, 436310990, 436299301, 436299302,
-    # TEC
-    #470340521, 470063045, 470063046, 470114669, 470114670, 470161093, 470161094, 470164333, 470164334, 470312005, 470312006, 470312009, 470067405, 470067406, 470128813
-]
+process.TrackerTrackHitFilter.detsToIgnore = []
 process.TrackerTrackHitFilter.replaceWithInactiveHits = True
 process.TrackerTrackHitFilter.stripAllInvalidHits = False
 process.TrackerTrackHitFilter.rejectBadStoNHits = True
@@ -1049,7 +984,7 @@
  ##
  ## Magnetic Field
  ##
-process.load("Configuration/StandardSequences/MagneticField_.oO[magneticField]Oo._cff")
+process.load("Configuration/StandardSequences/.oO[magneticField]Oo._cff")
 
 .oO[condLoad]Oo.
 
@@ -1132,15 +1067,7 @@
 process.TrackerTrackHitFilter.useTrajectories= True  # this is needed only if you require some selections; but it will work even if you don't ask for them
 process.TrackerTrackHitFilter.minimumHits = 8
 process.TrackerTrackHitFilter.commands = cms.vstring("keep PXB","keep PXE","keep TIB","keep TID","keep TOB","keep TEC")
-process.TrackerTrackHitFilter.detsToIgnore = [
-     # see https://hypernews.cern.ch/HyperNews/CMS/get/tracker-performance/484.html
-    # TIB / TID
-    #369136710, 369136714, 402668822,
-    # TOB
-    #436310989, 436310990, 436299301, 436299302,
-    # TEC
-    #470340521, 470063045, 470063046, 470114669, 470114670, 470161093, 470161094, 470164333, 470164334, 470312005, 470312006, 470312009, 470067405, 470067406, 470128813
-]
+process.TrackerTrackHitFilter.detsToIgnore = []
 process.TrackerTrackHitFilter.replaceWithInactiveHits = True
 process.TrackerTrackHitFilter.stripAllInvalidHits = False
 process.TrackerTrackHitFilter.rejectBadStoNHits = True
@@ -1210,15 +1137,7 @@
 process.TrackerTrackHitFilter.useTrajectories= True  # this is needed only if you require some selections; but it will work even if you don't ask for them
 process.TrackerTrackHitFilter.minimumHits = 8
 process.TrackerTrackHitFilter.commands = cms.vstring("keep PXB","keep PXE","keep TIB","keep TID","keep TOB","keep TEC")
-process.TrackerTrackHitFilter.detsToIgnore = [
-     # see https://hypernews.cern.ch/HyperNews/CMS/get/tracker-performance/484.html
-    # TIB / TID
-    #369136710, 369136714, 402668822,
-    # TOB
-    #436310989, 436310990, 436299301, 436299302,
-    # TEC
-    #470340521, 470063045, 470063046, 470114669, 470114670, 470161093, 470161094, 470164333, 470164334, 470312005, 470312006, 470312009, 470067405, 470067406, 470128813
-]
+process.TrackerTrackHitFilter.detsToIgnore = []
 process.TrackerTrackHitFilter.replaceWithInactiveHits = True
 process.TrackerTrackHitFilter.stripAllInvalidHits = False
 process.TrackerTrackHitFilter.rejectBadStoNHits = True
@@ -1291,16 +1210,7 @@
 process.TrackerTrackHitFilter.useTrajectories= True  # this is needed only if you require some selections; but it will work even if you don't ask for them
 process.TrackerTrackHitFilter.minimumHits = 8
 process.TrackerTrackHitFilter.commands = cms.vstring("keep PXB","keep PXE","keep TIB","keep TID","keep TOB","keep TEC")
-process.TrackerTrackHitFilter.detsToIgnore = [
-     # see https://hypernews.cern.ch/HyperNews/CMS/get/tracker-performance/484.html
-    # TIB / TID
-    #369136710, 369136714, 402668822,
-    # TOB
-    #436310989, 436310990, 436299301, 436299302,
-
-    # TEC
-    #470340521, 470063045, 470063046, 470114669, 470114670, 470161093, 470161094, 470164333, 470164334, 470312005, 470312006, 470312009, 470067405, 470067406, 470128813
-]
+process.TrackerTrackHitFilter.detsToIgnore = []
 process.TrackerTrackHitFilter.replaceWithInactiveHits = True
 process.TrackerTrackHitFilter.stripAllInvalidHits = False
 process.TrackerTrackHitFilter.rejectBadStoNHits = True
@@ -1365,15 +1275,7 @@
 process.TrackerTrackHitFilter.useTrajectories= True  # this is needed only if you require some selections; but it will work even if you don't ask for them
 process.TrackerTrackHitFilter.minimumHits = 8
 process.TrackerTrackHitFilter.commands = cms.vstring("keep PXB","keep PXE","keep TIB","keep TID","keep TOB","keep TEC")
-process.TrackerTrackHitFilter.detsToIgnore = [
-     # see https://hypernews.cern.ch/HyperNews/CMS/get/tracker-performance/484.html
-    # TIB / TID
-    #369136710, 369136714, 402668822,
-    # TOB
-    #436310989, 436310990, 436299301, 436299302,
-    # TEC
-    #470340521, 470063045, 470063046, 470114669, 470114670, 470161093, 470161094, 470164333, 470164334, 470312005, 470312006, 470312009, 470067405, 470067406, 470128813
-]
+process.TrackerTrackHitFilter.detsToIgnore = []
 process.TrackerTrackHitFilter.replaceWithInactiveHits = True
 process.TrackerTrackHitFilter.stripAllInvalidHits = False
 process.TrackerTrackHitFilter.rejectBadStoNHits = True