Merge pull request #23471 from fwyzard/fix_HcalHashFunctions

Fix the length of the string buffer to accommodate the "new format" of the HCAL DetId
cms-sw · Jun 6, 2018 · b8aa734 · b8aa734
2 parents 96f61ee + f61bc2b
commit b8aa734
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/DQM/HcalCommon/src/HashFunctions.cc b/DQM/HcalCommon/src/HashFunctions.cc
@@ -250,8 +250,8 @@ namespace hcaldqm
 
 		std::string name_HFPMiphi(HcalDetId const& did)
 		{
-			char name[10];
-			sprintf(name, "HF%siphi%d", did.ieta()>0 ? "P" : "M", did.iphi());
+			char name[12];
+			snprintf(name, sizeof(name), "HF%ciphi%d", did.ieta()>0 ? 'P' : 'M', did.iphi());
 			return std::string(name);
 		}