Skip to content

Commit

Permalink
add protection for Phase-0
Browse files Browse the repository at this point in the history
  • Loading branch information
@mmusich
mmusich committed Jul 5, 2021
1 parent f6fb8e5 commit b982aff
Showing 1 changed file with 87 additions and 37 deletions.
124 changes: 87 additions & 37 deletions CondCore/SiPixelPlugins/plugins/SiPixelQuality_PayloadInspector.cc
View file
Expand Up @@ -14,6 +14,7 @@
#include "CondCore/SiPixelPlugins/interface/SiPixelPayloadInspectorHelper.h"
#include "FWCore/ParameterSet/interface/FileInPath.h"
#include "CalibTracker/StandaloneTrackerTopology/interface/StandaloneTrackerTopology.h"
#include "CalibTracker/SiPixelESProducers/interface/SiPixelDetInfoFileReader.h"

// the data format of the condition to be inspected
#include "CondFormats/SiPixelObjects/interface/SiPixelQuality.h"
Expand All @@ -39,18 +40,19 @@

namespace {

//using namespace cond::payloadInspector;
using namespace cond::payloadInspector;

const std::string k_Ph0_geo = "CalibTracker/SiPixelESProducers/data/PixelSkimmedGeometry.txt";
const std::string k_Ph1_geo = "SLHCUpgradeSimulations/Geometry/data/PhaseI/PixelSkimmedGeometry_phase1.txt";

/************************************************
test class
*************************************************/

class SiPixelQualityTest
: public cond::payloadInspector::Histogram1D<SiPixelQuality, cond::payloadInspector::SINGLE_IOV> {
class SiPixelQualityTest : public Histogram1D<SiPixelQuality, SINGLE_IOV> {
public:
SiPixelQualityTest()
: cond::payloadInspector::Histogram1D<SiPixelQuality, cond::payloadInspector::SINGLE_IOV>(
"SiPixelQuality test", "SiPixelQuality test", 10, 0.0, 10.0) {}
: Histogram1D<SiPixelQuality, SINGLE_IOV>("SiPixelQuality test", "SiPixelQuality test", 10, 0.0, 10.0) {}

bool fill() override {
auto tag = PlotBase::getTag<0>();
Expand Down Expand Up @@ -79,12 +81,9 @@ namespace {
summary class
*************************************************/

class SiPixelQualityBadRocsSummary
: public cond::payloadInspector::PlotImage<SiPixelQuality, cond::payloadInspector::MULTI_IOV, 1> {
class SiPixelQualityBadRocsSummary : public PlotImage<SiPixelQuality, MULTI_IOV, 1> {
public:
SiPixelQualityBadRocsSummary()
: cond::payloadInspector::PlotImage<SiPixelQuality, cond::payloadInspector::MULTI_IOV, 1>(
"SiPixel Quality Summary") {}
SiPixelQualityBadRocsSummary() : PlotImage<SiPixelQuality, MULTI_IOV, 1>("SiPixel Quality Summary") {}

bool fill() override {
auto tag = PlotBase::getTag<0>();
Expand Down Expand Up @@ -119,12 +118,10 @@ namespace {
time history class
*************************************************/

class SiPixelQualityBadRocsTimeHistory
: public cond::payloadInspector::TimeHistoryPlot<SiPixelQuality, std::pair<double, double> > {
class SiPixelQualityBadRocsTimeHistory : public TimeHistoryPlot<SiPixelQuality, std::pair<double, double> > {
public:
SiPixelQualityBadRocsTimeHistory()
: cond::payloadInspector::TimeHistoryPlot<SiPixelQuality, std::pair<double, double> >("bad ROCs count vs time",
"bad ROCs count") {}
: TimeHistoryPlot<SiPixelQuality, std::pair<double, double> >("bad ROCs count vs time", "bad ROCs count") {}

std::pair<double, double> getFromPayload(SiPixelQuality& payload) override {
return std::make_pair(extractBadRocCount(payload), 0.);
Expand All @@ -148,12 +145,10 @@ namespace {
occupancy style map whole Pixel
*************************************************/
template <SiPixelPI::DetType myType>
class SiPixelQualityMap
: public cond::payloadInspector::PlotImage<SiPixelQuality, cond::payloadInspector::SINGLE_IOV> {
class SiPixelQualityMap : public PlotImage<SiPixelQuality, SINGLE_IOV> {
public:
SiPixelQualityMap()
: cond::payloadInspector::PlotImage<SiPixelQuality, cond::payloadInspector::SINGLE_IOV>(
"SiPixelQuality Pixel Map"),
: PlotImage<SiPixelQuality, SINGLE_IOV>("SiPixelQuality Pixel Map"),
m_trackerTopo{StandaloneTrackerTopology::fromTrackerParametersXMLFile(
edm::FileInPath("Geometry/TrackerCommonData/data/PhaseI/trackerParameters.xml").fullPath())} {}

Expand All @@ -166,6 +161,16 @@ namespace {
Phase1PixelROCMaps theMap("");

auto theDisabledModules = payload->getBadComponentList();
if (this->isPhase0(theDisabledModules)) {
edm::LogError("SiPixelQuality_PayloadInspector")
<< "SiPixelQuality maps are not supported for non-Phase1 Pixel geometries !";
TCanvas canvas("Canv", "Canv", 1200, 1000);
SiPixelPI::displayNotSupported(canvas, 0);
std::string fileName(m_imageFileName);
canvas.SaveAs(fileName.c_str());
return false;
}

for (const auto& mod : theDisabledModules) {
int subid = DetId(mod.DetID).subdetId();

Expand Down Expand Up @@ -220,6 +225,26 @@ namespace {
private:
static constexpr std::array<int, 3> k_height = {{1200, 600, 1600}};
TrackerTopology m_trackerTopo;

//_________________________________________________
bool isPhase0(std::vector<SiPixelQuality::disabledModuleType> mods) {
SiPixelDetInfoFileReader reader = SiPixelDetInfoFileReader(edm::FileInPath(k_Ph0_geo).fullPath());
const auto& p0detIds = reader.getAllDetIds();

std::vector<uint32_t> ownDetIds;
std::transform(mods.begin(),
mods.end(),
std::back_inserter(ownDetIds),
[](SiPixelQuality::disabledModuleType d) -> uint32_t { return d.DetID; });

for (const auto& det : ownDetIds) {
// if found at least one phase-0 detId early return
if (std::find(p0detIds.begin(), p0detIds.end(), det) != p0detIds.end()) {
return true;
}
}
return false;
}
};

using SiPixelBPixQualityMap = SiPixelQualityMap<SiPixelPI::t_barrel>;
Expand All @@ -229,19 +254,19 @@ namespace {
/************************************************
occupancy style map whole Pixel, difference of payloads
*************************************************/
template <SiPixelPI::DetType myType, cond::payloadInspector::IOVMultiplicity nIOVs, int ntags>
class SiPixelQualityMapComparisonBase : public cond::payloadInspector::PlotImage<SiPixelQuality, nIOVs, ntags> {
template <SiPixelPI::DetType myType, IOVMultiplicity nIOVs, int ntags>
class SiPixelQualityMapComparisonBase : public PlotImage<SiPixelQuality, nIOVs, ntags> {
public:
SiPixelQualityMapComparisonBase()
: cond::payloadInspector::PlotImage<SiPixelQuality, nIOVs, ntags>(
: PlotImage<SiPixelQuality, nIOVs, ntags>(
Form("SiPixelQuality %s Pixel Map", SiPixelPI::DetNames[myType].c_str())),
m_trackerTopo{StandaloneTrackerTopology::fromTrackerParametersXMLFile(
edm::FileInPath("Geometry/TrackerCommonData/data/PhaseI/trackerParameters.xml").fullPath())} {}

bool fill() override {
// trick to deal with the multi-ioved tag and two tag case at the same time
auto theIOVs = cond::payloadInspector::PlotBase::getTag<0>().iovs;
auto f_tagname = cond::payloadInspector::PlotBase::getTag<0>().name;
auto theIOVs = PlotBase::getTag<0>().iovs;
auto f_tagname = PlotBase::getTag<0>().name;
std::string l_tagname = "";
auto firstiov = theIOVs.front();
std::tuple<cond::Time_t, cond::Hash> lastiov;
Expand All @@ -250,8 +275,8 @@ namespace {
assert(this->m_plotAnnotations.ntags < 3);

if (this->m_plotAnnotations.ntags == 2) {
auto tag2iovs = cond::payloadInspector::PlotBase::getTag<1>().iovs;
l_tagname = cond::payloadInspector::PlotBase::getTag<1>().name;
auto tag2iovs = PlotBase::getTag<1>().iovs;
l_tagname = PlotBase::getTag<1>().name;
lastiov = tag2iovs.front();
} else {
lastiov = theIOVs.back();
Expand All @@ -260,6 +285,16 @@ namespace {
std::shared_ptr<SiPixelQuality> last_payload = this->fetchPayload(std::get<1>(lastiov));
std::shared_ptr<SiPixelQuality> first_payload = this->fetchPayload(std::get<1>(firstiov));

if (this->isPhase0(first_payload) || this->isPhase0(last_payload)) {
edm::LogError("SiPixelQuality_PayloadInspector")
<< "SiPixelQuality comparison maps are not supported for non-Phase1 Pixel geometries !";
TCanvas canvas("Canv", "Canv", 1200, 1000);
SiPixelPI::displayNotSupported(canvas, 0);
std::string fileName(this->m_imageFileName);
canvas.SaveAs(fileName.c_str());
return false;
}

Phase1PixelROCMaps theMap("", "#Delta payload A - payload B");

gStyle->SetOptStat(0);
Expand Down Expand Up @@ -322,6 +357,27 @@ namespace {
static constexpr std::array<int, 3> k_height = {{1200, 600, 1600}};
TrackerTopology m_trackerTopo;

//_________________________________________________
bool isPhase0(const std::shared_ptr<SiPixelQuality>& payload) {
const auto mods = payload->getBadComponentList();
SiPixelDetInfoFileReader reader = SiPixelDetInfoFileReader(edm::FileInPath(k_Ph0_geo).fullPath());
const auto& p0detIds = reader.getAllDetIds();

std::vector<uint32_t> ownDetIds;
std::transform(mods.begin(),
mods.end(),
std::back_inserter(ownDetIds),
[](SiPixelQuality::disabledModuleType d) -> uint32_t { return d.DetID; });

for (const auto& det : ownDetIds) {
// if found at least one phase-0 detId early return
if (std::find(p0detIds.begin(), p0detIds.end(), det) != p0detIds.end()) {
return true;
}
}
return false;
}

//____________________________________________________________________________________________
void fillTheMapFromPayload(Phase1PixelROCMaps& theMap,
const std::shared_ptr<SiPixelQuality>& payload,
Expand All @@ -343,18 +399,12 @@ namespace {
}
};

using SiPixelBPixQualityMapCompareSingleTag =
SiPixelQualityMapComparisonBase<SiPixelPI::t_barrel, cond::payloadInspector::MULTI_IOV, 1>;
using SiPixelFPixQualityMapCompareSingleTag =
SiPixelQualityMapComparisonBase<SiPixelPI::t_forward, cond::payloadInspector::MULTI_IOV, 1>;
using SiPixelFullQualityMapCompareSingleTag =
SiPixelQualityMapComparisonBase<SiPixelPI::t_all, cond::payloadInspector::MULTI_IOV, 1>;
using SiPixelBPixQualityMapCompareTwoTags =
SiPixelQualityMapComparisonBase<SiPixelPI::t_barrel, cond::payloadInspector::SINGLE_IOV, 2>;
using SiPixelFPixQualityMapCompareTwoTags =
SiPixelQualityMapComparisonBase<SiPixelPI::t_forward, cond::payloadInspector::SINGLE_IOV, 2>;
using SiPixelFullQualityMapCompareTwoTags =
SiPixelQualityMapComparisonBase<SiPixelPI::t_all, cond::payloadInspector::SINGLE_IOV, 2>;
using SiPixelBPixQualityMapCompareSingleTag = SiPixelQualityMapComparisonBase<SiPixelPI::t_barrel, MULTI_IOV, 1>;
using SiPixelFPixQualityMapCompareSingleTag = SiPixelQualityMapComparisonBase<SiPixelPI::t_forward, MULTI_IOV, 1>;
using SiPixelFullQualityMapCompareSingleTag = SiPixelQualityMapComparisonBase<SiPixelPI::t_all, MULTI_IOV, 1>;
using SiPixelBPixQualityMapCompareTwoTags = SiPixelQualityMapComparisonBase<SiPixelPI::t_barrel, SINGLE_IOV, 2>;
using SiPixelFPixQualityMapCompareTwoTags = SiPixelQualityMapComparisonBase<SiPixelPI::t_forward, SINGLE_IOV, 2>;
using SiPixelFullQualityMapCompareTwoTags = SiPixelQualityMapComparisonBase<SiPixelPI::t_all, SINGLE_IOV, 2>;

} // namespace

Expand Down

0 comments on commit b982aff

Please sign in to comment.