Merge pull request #39179 from missirol/devel_fixHLTPFJetMatchFilter

don't produce duplicate outputs in `HLTPFJetsMatchedToFilteredJetsProducer`
cms-sw · Sep 12, 2022 · e5ac8e9 · e5ac8e9
2 parents bf29957 + fc745bf
commit e5ac8e9
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/HLTrigger/JetMET/interface/HLTPFJetsMatchedToFilteredJetsProducer.h b/HLTrigger/JetMET/interface/HLTPFJetsMatchedToFilteredJetsProducer.h
@@ -47,7 +47,7 @@ HLTPFJetsMatchedToFilteredJetsProducer<TriggerJetsRefType>::HLTPFJetsMatchedToFi
       maxDeltaR2_(maxDeltaR_ * maxDeltaR_) {
   if (maxDeltaR_ <= 0.) {
     throw cms::Exception("HLTPFJetsMatchedToFilteredJetsProducerConfiguration")
-        << "invalid value for parameter \"DeltaR\" (must be > 0): " << maxDeltaR_;
+        << "invalid value for parameter \"maxDeltaR\" (must be > 0): " << maxDeltaR_;
   }
 
   produces<reco::PFJetCollection>();
@@ -58,7 +58,7 @@ void HLTPFJetsMatchedToFilteredJetsProducer<TriggerJetsRefType>::fillDescription
     edm::ConfigurationDescriptions& descriptions) {
   edm::ParameterSetDescription desc;
   desc.add<edm::InputTag>("src", edm::InputTag("hltPFJets"));
-  desc.add<edm::InputTag>("triggerJetsFilter", edm::InputTag("hltSingleJet240Regional"));
+  desc.add<edm::InputTag>("triggerJetsFilter", edm::InputTag("hltCaloJetsFiltered"));
   desc.add<int>("triggerJetsType", trigger::TriggerJet);
   desc.add<double>("maxDeltaR", 0.5);
   descriptions.addWithDefaultLabel(desc);
@@ -71,19 +71,17 @@ void HLTPFJetsMatchedToFilteredJetsProducer<TriggerJetsRefType>::produce(edm::St
   auto const& recoCands = iEvent.get(recoCandsToken_);
 
   std::vector<TriggerJetsRefType> triggerJetsRefVec;
-  auto const& triggerJets = iEvent.get(triggerJetsToken_);
-  triggerJets.getObjects(triggerJetsType_, triggerJetsRefVec);
+  iEvent.get(triggerJetsToken_).getObjects(triggerJetsType_, triggerJetsRefVec);
 
   math::XYZPoint const pvtxPoint(0., 0., 0.);
   reco::PFJet::Specific const pfJetSpec;
 
   auto outPFJets = std::make_unique<reco::PFJetCollection>();
   outPFJets->reserve(recoCands.size());
 
-  for (auto const& iJetRef : triggerJetsRefVec) {
-    for (auto const& jRecoCand : recoCands) {
-      auto const dR2 = reco::deltaR2(jRecoCand.p4(), iJetRef->p4());
-      if (dR2 < maxDeltaR2_) {
+  for (auto const& jRecoCand : recoCands) {
+    for (auto const& iJetRef : triggerJetsRefVec) {
+      if (reco::deltaR2(jRecoCand.p4(), iJetRef->p4()) < maxDeltaR2_) {
         outPFJets->emplace_back(jRecoCand.p4(), pvtxPoint, pfJetSpec);
         break;
       }