clang10 warnings fixed

cms-sw · May 8, 2020 · e7fc1d9 · e7fc1d9
1 parent 8c0e2bf
commit e7fc1d9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/L1Trigger/L1TMuonOverlap/src/OMTFinputMaker.cc b/L1Trigger/L1TMuonOverlap/src/OMTFinputMaker.cc
@@ -217,7 +217,7 @@ OMTFinput OMTFinputMaker::processDT(const L1MuDTChambPhContainer *dtPhDigis,
   if (!dtPhDigis)
     return result;
 
-  for (const auto digiIt : *dtPhDigis->getContainer()) {
+  for (const auto &digiIt : *dtPhDigis->getContainer()) {
     DTChamberId detid(digiIt.whNum(), digiIt.stNum(), digiIt.scNum() + 1);
 
     ///Check it the data fits into given processor input range

diff --git a/L1TriggerConfig/L1TConfigProducers/src/L1TGlobalPrescalesVetosOnlineProd.cc b/L1TriggerConfig/L1TConfigProducers/src/L1TGlobalPrescalesVetosOnlineProd.cc
@@ -614,7 +614,7 @@ std::unique_ptr<const L1TGlobalPrescalesVetos> L1TGlobalPrescalesVetosOnlineProd
         << "\nWarning: No default found in BX mask xml, used 1 (unmasked) as default" << std::endl;
   }
 
-  for (const std::pair<std::string, std::set<Range_t, RangeComp_t>> &algo : non_default_bx_ranges) {
+  for (auto &algo : non_default_bx_ranges) {
     const std::string &algoName = algo.first;
     unsigned int algoBit = algoName2bit[algoName];
     for (auto range : algo.second)

diff --git a/SimCalorimetry/HcalTrigPrimAlgos/src/HcalTriggerPrimitiveAlgo.cc b/SimCalorimetry/HcalTrigPrimAlgos/src/HcalTriggerPrimitiveAlgo.cc
@@ -812,7 +812,7 @@ void HcalTriggerPrimitiveAlgo::addUpgradeFG(const HcalTrigTowerDetId& id,
 }
 
 void HcalTriggerPrimitiveAlgo::setPeakFinderAlgorithm(int algo) {
-  if (algo <= 0 && algo > 2)
+  if (algo <= 0 || algo > 2)
     throw cms::Exception("ERROR: Only algo 1 & 2 are supported.") << std::endl;
   peak_finder_algorithm_ = algo;
 }