Remove the class-level deprecation annotation from legacy EDModules

While in principle annotating the entire class would be the proper
thing to do, with gcc the constructor annotation appears to work
better for identifying the deriving classes that need to be migrated
to thread-friendly base classes.

FWCore/Framework/interface/EDAnalyzer.h

@@ -26,7 +26,13 @@ namespace edm {
     class ModuleHolderT;
   }
 
-  class CMS_DEPRECATED EDAnalyzer : public EDConsumerBase {
+  /**
+   * The legacy EDAnalyzer class is deprecated. We annotate the
+   * constructor only with the CMS_DEPRECATED, because with gcc it
+   * turns out to flag deriving classes more reliably than annotating
+   * the entire class.
+   */
+  class EDAnalyzer : public EDConsumerBase {
   public:
     template <typename T>
     friend class maker::ModuleHolderT;

FWCore/Framework/interface/EDFilter.h

@@ -36,7 +36,13 @@ namespace edm {
   class ActivityRegistry;
   class ThinnedAssociationsHelper;
 
-  class CMS_DEPRECATED EDFilter : public ProducerBase, public EDConsumerBase {
+  /**
+   * The legacy EDFilter class is deprecated. We annotate the
+   * constructor only with the CMS_DEPRECATED, because with gcc it
+   * turns out to flag deriving classes more reliably than annotating
+   * the entire class.
+   */
+  class EDFilter : public ProducerBase, public EDConsumerBase {
   public:
     template <typename T>
     friend class maker::ModuleHolderT;

FWCore/Framework/interface/EDProducer.h

@@ -33,7 +33,13 @@ namespace edm {
     class ModuleHolderT;
   }
 
-  class CMS_DEPRECATED EDProducer : public ProducerBase, public EDConsumerBase {
+  /**
+   * The legacy EDProducer class is deprecated. We annotate the
+   * constructor only with the CMS_DEPRECATED, because with gcc it
+   * turns out to flag deriving classes more reliably than annotating
+   * the entire class.
+   */
+  class EDProducer : public ProducerBase, public EDConsumerBase {
   public:
     template <typename T>
     friend class maker::ModuleHolderT;