Skip to content

Commit

Permalink
Merge pull request #22690 from fabiocos/fc-fixSiStripDQMcrash
Browse files Browse the repository at this point in the history
Temporarily disable SiStripMonitorClient BadChannel sequences (crash due to PR 22373)
  • Loading branch information
cmsbuild committed Mar 21, 2018
2 parents 3b5dd32 + 77374d2 commit f6d0289
Show file tree
Hide file tree
Showing 3 changed files with 62 additions and 59 deletions.
Expand Up @@ -21,29 +21,30 @@
getQualityTestsFromFile = cms.untracked.bool(True)
)

from CalibTracker.SiStripESProducers.SiStripBadModuleFedErrESSource_cfi import*
siStripBadModuleFedErrESSource.appendToDataLabel = cms.string('BadModules_from_FEDBadChannel')
siStripBadModuleFedErrESSource.ReadFromFile = cms.bool(False)

from CalibTracker.SiStripESProducers.SiStripQualityESProducer_cfi import*
siStripQualityESProducer.ListOfRecordToMerge = cms.VPSet(
cms.PSet(record = cms.string("SiStripDetVOffRcd"), tag = cms.string('')), # DCS information
cms.PSet(record = cms.string('SiStripDetCablingRcd'), tag = cms.string('')), # Use Detector cabling information to exclude detectors not connected
cms.PSet(record = cms.string('SiStripBadChannelRcd'), tag = cms.string('')), # Online Bad components
cms.PSet(record = cms.string('SiStripBadFiberRcd'), tag = cms.string('')), # Bad Channel list from the selected IOV as done at PCL
cms.PSet(record = cms.string('SiStripBadModuleFedErrRcd'), tag = cms.string('BadModules_from_FEDBadChannel')), # BadChannel list from FED erroes
cms.PSet(record = cms.string('RunInfoRcd'), tag = cms.string('')) # List of FEDs exluded during data taking
)
siStripQualityESProducer.ReduceGranularity = cms.bool(False)
siStripQualityESProducer.ThresholdForReducedGranularity = cms.double(0.3)
siStripQualityESProducer.appendToDataLabel = 'MergedBadComponent'

siStripBadComponentInfo = cms.EDProducer("SiStripBadComponentInfo",
StripQualityLabel = cms.string('MergedBadComponent')
)
# from CalibTracker.SiStripESProducers.SiStripBadModuleFedErrESSource_cfi import*
# siStripBadModuleFedErrESSource.appendToDataLabel = cms.string('BadModules_from_FEDBadChannel')
# siStripBadModuleFedErrESSource.ReadFromFile = cms.bool(False)

# from CalibTracker.SiStripESProducers.SiStripQualityESProducer_cfi import*
# siStripQualityESProducer.ListOfRecordToMerge = cms.VPSet(
# cms.PSet(record = cms.string("SiStripDetVOffRcd"), tag = cms.string('')), # DCS information
# cms.PSet(record = cms.string('SiStripDetCablingRcd'), tag = cms.string('')), # Use Detector cabling information to exclude detectors not connected
# cms.PSet(record = cms.string('SiStripBadChannelRcd'), tag = cms.string('')), # Online Bad components
# cms.PSet(record = cms.string('SiStripBadFiberRcd'), tag = cms.string('')), # Bad Channel list from the selected IOV as done at PCL
# cms.PSet(record = cms.string('SiStripBadModuleFedErrRcd'), tag = cms.string('BadModules_from_FEDBadChannel')), # BadChannel list from FED erroes
# cms.PSet(record = cms.string('RunInfoRcd'), tag = cms.string('')) # List of FEDs exluded during data taking
# )
# siStripQualityESProducer.ReduceGranularity = cms.bool(False)
# siStripQualityESProducer.ThresholdForReducedGranularity = cms.double(0.3)
# siStripQualityESProducer.appendToDataLabel = 'MergedBadComponent'

# siStripBadComponentInfo = cms.EDProducer("SiStripBadComponentInfo",
# StripQualityLabel = cms.string('MergedBadComponent')
# )

# Sequence
SiStripCosmicDQMClient = cms.Sequence(siStripQTester*siStripOfflineAnalyser*siStripBadComponentInfo)
# SiStripCosmicDQMClient = cms.Sequence(siStripQTester*siStripOfflineAnalyser*siStripBadComponentInfo)
SiStripCosmicDQMClient = cms.Sequence(siStripQTester*siStripOfflineAnalyser)
#removed modules using TkDetMap
#SiStripCosmicDQMClient = cms.Sequence(siStripQTester)

Expand Down
Expand Up @@ -32,31 +32,32 @@
getQualityTestsFromFile = cms.untracked.bool(True)
)

from CalibTracker.SiStripESProducers.SiStripBadModuleFedErrESSource_cfi import*
siStripBadModuleFedErrESSource.appendToDataLabel = cms.string('BadModules_from_FEDBadChannel')
siStripBadModuleFedErrESSource.ReadFromFile = cms.bool(False)
# from CalibTracker.SiStripESProducers.SiStripBadModuleFedErrESSource_cfi import*
# siStripBadModuleFedErrESSource.appendToDataLabel = cms.string('BadModules_from_FEDBadChannel')
# siStripBadModuleFedErrESSource.ReadFromFile = cms.bool(False)

from CalibTracker.SiStripESProducers.SiStripQualityESProducer_cfi import*
siStripQualityESProducer.ListOfRecordToMerge = cms.VPSet(
cms.PSet(record = cms.string("SiStripDetVOffRcd"), tag = cms.string('')), # DCS information
cms.PSet(record = cms.string('SiStripDetCablingRcd'), tag = cms.string('')), # Use Detector cabling information to exclude detectors not connected
cms.PSet(record = cms.string('SiStripBadChannelRcd'), tag = cms.string('')), # Online Bad components
cms.PSet(record = cms.string('SiStripBadFiberRcd'), tag = cms.string('')), # Bad Channel list from the selected IOV as done at PCL
cms.PSet(record = cms.string('SiStripBadModuleFedErrRcd'), tag = cms.string('BadModules_from_FEDBadChannel')), # BadChannel list from FED erroes
cms.PSet(record = cms.string('RunInfoRcd'), tag = cms.string('')) # List of FEDs exluded during data taking
)
siStripQualityESProducer.ReduceGranularity = cms.bool(False)
siStripQualityESProducer.ThresholdForReducedGranularity = cms.double(0.3)
siStripQualityESProducer.appendToDataLabel = 'MergedBadComponent'
# from CalibTracker.SiStripESProducers.SiStripQualityESProducer_cfi import*
# siStripQualityESProducer.ListOfRecordToMerge = cms.VPSet(
# cms.PSet(record = cms.string("SiStripDetVOffRcd"), tag = cms.string('')), # DCS information
# cms.PSet(record = cms.string('SiStripDetCablingRcd'), tag = cms.string('')), # Use Detector cabling information to exclude detectors not connected
# cms.PSet(record = cms.string('SiStripBadChannelRcd'), tag = cms.string('')), # Online Bad components
# cms.PSet(record = cms.string('SiStripBadFiberRcd'), tag = cms.string('')), # Bad Channel list from the selected IOV as done at PCL
# cms.PSet(record = cms.string('SiStripBadModuleFedErrRcd'), tag = cms.string('BadModules_from_FEDBadChannel')), # BadChannel list from FED erroes
# cms.PSet(record = cms.string('RunInfoRcd'), tag = cms.string('')) # List of FEDs exluded during data taking
# )
# siStripQualityESProducer.ReduceGranularity = cms.bool(False)
# siStripQualityESProducer.ThresholdForReducedGranularity = cms.double(0.3)
# siStripQualityESProducer.appendToDataLabel = 'MergedBadComponent'

siStripBadComponentInfo = cms.EDProducer("SiStripBadComponentInfo",
StripQualityLabel = cms.string('MergedBadComponent')
)
# siStripBadComponentInfo = cms.EDProducer("SiStripBadComponentInfo",
# StripQualityLabel = cms.string('MergedBadComponent')
# )

# define new HI sequence
#removed modules using TkDetMap
#SiStripOfflineDQMClientHI = cms.Sequence(siStripQTesterHI)
SiStripOfflineDQMClientHI = cms.Sequence(siStripQTesterHI*siStripOfflineAnalyser*siStripBadComponentInfo)
# SiStripOfflineDQMClientHI = cms.Sequence(siStripQTesterHI*siStripOfflineAnalyser*siStripBadComponentInfo)
SiStripOfflineDQMClientHI = cms.Sequence(siStripQTesterHI*siStripOfflineAnalyser)

# Services needed for TkHistoMap
from CalibTracker.SiStripCommon.TkDetMap_cff import *
39 changes: 20 additions & 19 deletions DQM/SiStripMonitorClient/python/SiStripClientConfig_Tier0_cff.py
Expand Up @@ -37,30 +37,31 @@
getQualityTestsFromFile = cms.untracked.bool(True)
)

from CalibTracker.SiStripESProducers.SiStripBadModuleFedErrESSource_cfi import*
siStripBadModuleFedErrESSource.appendToDataLabel = cms.string('BadModules_from_FEDBadChannel')
siStripBadModuleFedErrESSource.ReadFromFile = cms.bool(False)
# from CalibTracker.SiStripESProducers.SiStripBadModuleFedErrESSource_cfi import*
# siStripBadModuleFedErrESSource.appendToDataLabel = cms.string('BadModules_from_FEDBadChannel')
# siStripBadModuleFedErrESSource.ReadFromFile = cms.bool(False)

from CalibTracker.SiStripESProducers.SiStripQualityESProducer_cfi import*
siStripQualityESProducer.ListOfRecordToMerge = cms.VPSet(
cms.PSet(record = cms.string("SiStripDetVOffRcd"), tag = cms.string('')), # DCS information
cms.PSet(record = cms.string('SiStripDetCablingRcd'), tag = cms.string('')), # Use Detector cabling information to exclude detectors not connected
cms.PSet(record = cms.string('SiStripBadChannelRcd'), tag = cms.string('')), # Online Bad components
cms.PSet(record = cms.string('SiStripBadFiberRcd'), tag = cms.string('')), # Bad Channel list from the selected IOV as done at PCL
cms.PSet(record = cms.string('SiStripBadModuleFedErrRcd'), tag = cms.string('BadModules_from_FEDBadChannel')), # BadChannel list from FED erroes
cms.PSet(record = cms.string('RunInfoRcd'), tag = cms.string('')) # List of FEDs exluded during data taking
)
siStripQualityESProducer.ReduceGranularity = cms.bool(False)
siStripQualityESProducer.ThresholdForReducedGranularity = cms.double(0.3)
siStripQualityESProducer.appendToDataLabel = 'MergedBadComponent'
# from CalibTracker.SiStripESProducers.SiStripQualityESProducer_cfi import*
# siStripQualityESProducer.ListOfRecordToMerge = cms.VPSet(
# cms.PSet(record = cms.string("SiStripDetVOffRcd"), tag = cms.string('')), # DCS information
# cms.PSet(record = cms.string('SiStripDetCablingRcd'), tag = cms.string('')), # Use Detector cabling information to exclude detectors not connected
# cms.PSet(record = cms.string('SiStripBadChannelRcd'), tag = cms.string('')), # Online Bad components
# cms.PSet(record = cms.string('SiStripBadFiberRcd'), tag = cms.string('')), # Bad Channel list from the selected IOV as done at PCL
# cms.PSet(record = cms.string('SiStripBadModuleFedErrRcd'), tag = cms.string('BadModules_from_FEDBadChannel')), # BadChannel list from FED erroes
# cms.PSet(record = cms.string('RunInfoRcd'), tag = cms.string('')) # List of FEDs exluded during data taking
# )
# siStripQualityESProducer.ReduceGranularity = cms.bool(False)
# siStripQualityESProducer.ThresholdForReducedGranularity = cms.double(0.3)
# siStripQualityESProducer.appendToDataLabel = 'MergedBadComponent'

siStripBadComponentInfo = cms.EDProducer("SiStripBadComponentInfo",
StripQualityLabel = cms.string('MergedBadComponent')
)
# siStripBadComponentInfo = cms.EDProducer("SiStripBadComponentInfo",
# StripQualityLabel = cms.string('MergedBadComponent')
# )


# Sequence
SiStripOfflineDQMClient = cms.Sequence(siStripQTester*siStripOfflineAnalyser*siStripBadComponentInfo)
# SiStripOfflineDQMClient = cms.Sequence(siStripQTester*siStripOfflineAnalyser*siStripBadComponentInfo)
SiStripOfflineDQMClient = cms.Sequence(siStripQTester*siStripOfflineAnalyser)
#removed modules using TkDetMap
#SiStripOfflineDQMClient = cms.Sequence(siStripQTester)

Expand Down

0 comments on commit f6d0289

Please sign in to comment.